linting

Author: VineetBala-AOT

analytics-api/src/analytics_api/models/request_type_option.py

@@ -55,18 +55,18 @@ def get_survey_result(
         if result:
             # Get all the available responses for each question within the survey.
             available_response = (db.session.query(AvailableResponseOptionModel.request_key,
-                                                AvailableResponseOptionModel.value)
-                                .filter(and_(AvailableResponseOptionModel.survey_id.in_(
-                                    analytics_survey_id), AvailableResponseOptionModel.is_active == true()))
-                                .subquery())
+                                                   AvailableResponseOptionModel.value)
+                                  .filter(and_(AvailableResponseOptionModel.survey_id.in_(
+                                      analytics_survey_id), AvailableResponseOptionModel.is_active == true()))
+                                  .subquery())
             # Get all the survey responses with the counts for each response specific to a survey id which
             # are in active status.
             survey_response = (db.session.query(ResponseTypeOptionModel.request_key, ResponseTypeOptionModel.value,
                                                 func.count(ResponseTypeOptionModel.request_key).label('response'))
-                            .filter(and_(ResponseTypeOptionModel.survey_id.in_(analytics_survey_id),
+                               .filter(and_(ResponseTypeOptionModel.survey_id.in_(analytics_survey_id),
                                             ResponseTypeOptionModel.is_active == true()))
-                            .group_by(ResponseTypeOptionModel.request_key, ResponseTypeOptionModel.value)
-                            .subquery())
+                               .group_by(ResponseTypeOptionModel.request_key, ResponseTypeOptionModel.value)
+                               .subquery())
 
             survey_response_exists = db.session.query(survey_response.c.request_key).first()
             available_response_exists = db.session.query(available_response.c.request_key).first()
@@ -81,33 +81,33 @@ def get_survey_result(
             # which fetches all the available responses along with the corresponding reponses.
             if survey_response_exists and available_response_exists:
                 survey_result = (db.session.query((survey_question.c.position).label('position'),
-                                                (survey_question.c.label).label('question'),
-                                                func.json_agg(func.json_build_object(
-                                                    'value', available_response.c.value,
-                                                    'count', func.coalesce(survey_response.c.response, 0)))
-                                .label('result'))
-                                .outerjoin(available_response, survey_question.c.key == available_response.c.request_key)
-                                .outerjoin(survey_response,
+                                                  (survey_question.c.label).label('question'),
+                                                  func.json_agg(func.json_build_object(
+                                                      'value', available_response.c.value,
+                                                      'count', func.coalesce(survey_response.c.response, 0)))
+                                 .label('result'))
+                                 .outerjoin(available_response, survey_question.c.key == available_response.c.request_key)
+                                 .outerjoin(survey_response,
                                             (available_response.c.value == survey_response.c.value) &
                                             (available_response.c.request_key == survey_response.c.request_key),
                                             full=True)
-                                .filter(survey_question.c.position.isnot(None))
-                                .filter(survey_question.c.label.isnot(None))
-                                .group_by(survey_question.c.position, survey_question.c.label))
+                                 .filter(survey_question.c.position.isnot(None))
+                                 .filter(survey_question.c.label.isnot(None))
+                                 .group_by(survey_question.c.position, survey_question.c.label))
 
                 return survey_result.all()
             # Check if there are records in survey_response before executing the final query which fetches reponses
             # even if the available_response table is not yet populated.
             if survey_response_exists:
                 survey_result = (db.session.query((survey_question.c.position).label('position'),
-                                                (survey_question.c.label).label('question'),
-                                                func.json_agg(func.json_build_object('value',
-                                                                                    survey_response.c.value,
-                                                                                    'count',
-                                                                                    survey_response.c.response))
-                                .label('result'))
-                                .join(survey_response, survey_response.c.request_key == survey_question.c.key)
-                                .group_by(survey_question.c.position, survey_question.c.label))
+                                                  (survey_question.c.label).label('question'),
+                                                  func.json_agg(func.json_build_object('value',
+                                                                                       survey_response.c.value,
+                                                                                       'count',
+                                                                                       survey_response.c.response))
+                                 .label('result'))
+                                 .join(survey_response, survey_response.c.request_key == survey_question.c.key)
+                                 .group_by(survey_question.c.position, survey_question.c.label))
 
                 return survey_result.all()
 

analytics-api/src/analytics_api/utils/engagement_access_validator.py

@@ -18,7 +18,7 @@ def check_engagement_access(engagement_id):
                 EngagementModel.is_active == true(),
                 or_(
                     EngagementModel.status_name == Status.Unpublished.value,
-                    EngagementModel.send_report == False
+                    EngagementModel.send_report.is_(False)
                 )
             )
         )