Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recreated CE-1054 directly on the Orca release avoiding the rebase. #667

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

gregorylavery
Copy link
Collaborator

@gregorylavery gregorylavery commented Sep 26, 2024

Description

Requires case-management fix to work - will update the values in the sector dropdown based upon the schedulesectorxref table in case-management. Allows the user to select the right sector and save it based upon the schedule type.

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)
CE-1054

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Create a decision for the complaint, save the data, reload the data and change the schedule type, resave the data.
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@afwilcox afwilcox added the case_management_1 https://dc0a4a-compenf-dev-1-backend.apps.emerald.devops.gov.bc.ca/graphql label Sep 27, 2024
Copy link

sonarcloud bot commented Sep 27, 2024

@@ -36,7 +37,23 @@ export const selectSectorDropdown = (state: RootState): Array<Option> => {

return data;
};
export const selectScheduleSectorDropdown = (state: RootState): Array<Option> => {
const {
codeTables: { sector: items, "schedule-sector": scheduleSector },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like scheduleSector isn't used, and can be removed.

@afwilcox afwilcox merged commit c94398e into release/orca Sep 27, 2024
15 checks passed
@afwilcox afwilcox deleted the CE_1054-Orca_Release_fix branch September 27, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
case_management_1 https://dc0a4a-compenf-dev-1-backend.apps.emerald.devops.gov.bc.ca/graphql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants