Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move gwells backend and fronted to root folder. Dockerfile's moved to related app root folder. #29

Merged
merged 3 commits into from
Aug 7, 2024
Merged

chore: Move gwells backend and fronted to root folder. Dockerfile's moved to related app root folder. #29

merged 3 commits into from
Aug 7, 2024

Conversation

fergmac
Copy link
Collaborator

@fergmac fergmac commented Aug 7, 2024 •
edited by github-actions bot
Loading

…ective app folder.

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@fergmac fergmac self-assigned this Aug 7, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2024
View reviewed changes
backend/Dockerfile
@@ -1,25 +1,17 @@
# Build
FROM node:22.5.1-slim AS build
FROM python:3.7-slim

Check failure

Code scanning / Trivy

Image user should not be 'root'

Artifact: backend/Dockerfile Type: dockerfile Vulnerability DS002 Severity: HIGH Message: Specify at least 1 USER command in Dockerfile with non-root user as argument Link: [DS002](https://avd.aquasec.com/misconfig/ds002)
backend/Dockerfile
@@ -1,25 +1,17 @@
# Build
FROM node:22.5.1-slim AS build
FROM python:3.7-slim

Check notice

Code scanning / Trivy

No HEALTHCHECK defined

Artifact: backend/Dockerfile Type: dockerfile Vulnerability DS026 Severity: LOW Message: Add HEALTHCHECK instruction in your Dockerfile Link: [DS026](https://avd.aquasec.com/misconfig/ds026)
backend/Dockerfile
COPY . ./
ENV PRISMA_CLI_BINARY_TARGETS debian-openssl-3.0.x
RUN npm run deploy
RUN apt-get -y update

Check failure

Code scanning / Trivy

'RUN <package-manager> update' instruction alone

Artifact: backend/Dockerfile Type: dockerfile Vulnerability DS017 Severity: HIGH Message: The instruction 'RUN <package-manager> update' should always be followed by '<package-manager> install' in the same RUN statement. Link: [DS017](https://avd.aquasec.com/misconfig/ds017)
backend/Dockerfile
RUN npm run deploy
RUN apt-get -y update

RUN apt-get -y install git build-essential libgdal-dev

Check failure

Code scanning / Trivy

&#39;apt-get&#39; missing &#39;--no-install-recommends&#39;

Artifact: backend/Dockerfile Type: dockerfile Vulnerability DS029 Severity: HIGH Message: '--no-install-recommends' flag is missed: 'apt-get -y install git build-essential libgdal-dev' Link: [DS029](https://avd.aquasec.com/misconfig/ds029)
@fergmac fergmac merged commit 63120c2 into main Aug 7, 2024
6 checks passed
@fergmac fergmac deleted the restructe-app-code branch August 7, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fergmac fergmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fergmac