Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR Pipeline to run UT #113

Open
mishraomp opened this issue Oct 18, 2024 · 5 comments
Open

Update PR Pipeline to run UT #113

mishraomp opened this issue Oct 18, 2024 · 5 comments
Assignees
@mishraomp

Comments

@mishraomp
Copy link
Contributor

mishraomp commented Oct 18, 2024 •
edited
Loading

Currently no UTs run during PR pipeline,

Once sonar is setup, update the PR pipeline to have UT and sonar checks.

bcgov/devops-requests#1734

FYI @acoard-aot
@mishraomp mishraomp self-assigned this Oct 18, 2024
@acoard-aot
Copy link
Contributor

Thanks Om, will do.

@acoard-aot
Copy link
Contributor

Handling in #121

@acoard-aot
Copy link
Contributor

@mishraomp, can you please grant me sufficient permissions to configure SonarCloud?

@acoard-aot
Copy link
Contributor

Also mind spot checking this run? Did it run okay? https://github.com/bcgov/nr-site-registry/actions/runs/11412320501/job/31758109467?pr=121

I can't fully tell if it's working without SonarCloud setup. But I would expect to see the logs from running the test, and don't seem to see that, even though the job runs okay.

@mishraomp
Copy link
Contributor Author

mishraomp commented Oct 19, 2024 •
edited
Loading

@acoard-aot I see the sonar tokens added already, so I think you got that already, for the tests not running since there are no changes to backend or frontend triggers not firing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mishraomp mishraomp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mishraomp @acoard-aot