feat(3636): track reasons for choosing cloud provider #3857
Conversation
golebu2020
commented
Sep 26, 2024
golebu2020
commented
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -193,7 +193,14 @@ export default publicCloudProductRequest(({ pathParams, queryParams, session, ro | |||
|
|
|||
| return ( | |||
| <div> | |||
| <PublicCloudBillingInfo product={publicSnap.currentRequest.decisionData} className="mb-2" /> | |||
| <PublicCloudBillingInfo | |||
There was a problem hiding this comment.
It seems you're adding these two fields to align with the type configuration. Instead of adding data, let's omit these two fields from the Product type in PublicCloudBillingInfo.
There was a problem hiding this comment.
I've tested the feature from my local environment and it works as expected.
There was a problem hiding this comment.
It seems you're adding these two fields to align with the type configuration. Instead of adding data, let's omit these two fields from the
Producttype inPublicCloudBillingInfo.
okay
There was a problem hiding this comment.
I've tested the feature from my local environment and it works as expected.
Did your local environment had a old public cloud data?
There was a problem hiding this comment.
No I don't. The sign MoU feature didn't allow me to go past the level of approving the product.
| @@ -20,3 +21,12 @@ export const getRandomUser = () => { | |||
| createdAt: new Date(), | |||
| }; | |||
| }; | |||
| export const getRandomCloudProviderSelectionReasons = () => { | |||
There was a problem hiding this comment.
I see duplicate function getRandomCloudProviderSelectionReasons from above.
| const randomNumberOfReasons = getRandomNumberOptimally(1, reasonForSelectingCloudProviderArray.length); | ||
| return faker.helpers.arrayElements(reasonForSelectingCloudProviderArray, randomNumberOfReasons); | ||
| }; | ||
| export const getRandomProviderReasonsNote = () => { |
There was a problem hiding this comment.
I see duplicate function getRandomProviderReasonsNote from above.
I've tested the feature from my local environment and it works as expected. |
golebu2020
force-pushed
the
feat/3636-A
branch
from
16c72ec
to
8b72df4
Compare
.bin/copy-db.sh
Outdated
| @@ -28,4 +28,5 @@ echo "Most recent file: $recent_file" | |||
|
|
|||
| # Copy the most recent back file to unarchive into the sandbox database | |||
| oc cp "$pod_name:backup/$recent_file" "$tmp_dir/$recent_file" | |||
| echo "pltsvc" | |||
.tool-versions
Outdated
| @@ -7,3 +7,4 @@ helm 3.16.1 | |||
| shfmt 3.9.0 | |||
| act 0.2.67 | |||
| jq 1.7.1 | |||
| database-tools 0.8.1 | |||
| reviewMou: boolean; | ||
| }; | ||
| }, | ||
| 'providerSelectionReasons' | 'providerSelectionReasonsNote' |
There was a problem hiding this comment.
try revert this to see if you still have issues.
app/components/billing/types.ts
Outdated
| @@ -12,5 +12,5 @@ export type Product = Omit< | |||
| }; | |||
| }; | |||
| }>, | |||
| 'updatedAt' | |||
| 'updatedAt' | 'providerSelectionReasons' | 'providerSelectionReasonsNote' | |||
There was a problem hiding this comment.
try revert this to see if you still have issues.
| export const up = async (db, client) => { | ||
| await db | ||
| .collection('PublicCloudRequestedProject') | ||
| .updateMany({ providerSelectionReasonsNote: null }, { $set: { providerSelectionReasonsNote: ' ' } }); |
There was a problem hiding this comment.
- let's merge these two files with
Promise.all. - in the
filterclause, check if the field exists as well
- $exists: false OR null
golebu2020
force-pushed
the
feat/3636-A
branch
2 times, most recently
from
5cca765
to
f9afa9b
Compare
golebu2020
force-pushed
the
feat/3636-A
branch
from
f9afa9b
to
7bac5ac
Compare
|
