Skip to content

Commit 010db0c

Browse files
20015 - Fixing modal not opening in details (#2740)
* Fixing modal not opening * Dropdown pointer * Passing props.selectedShortName * Watch update
1 parent 360b83f commit 010db0c

File tree

5 files changed

+17
-9
lines changed

5 files changed

+17
-9
lines changed

auth-web/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

auth-web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "auth-web",
3-
"version": "2.5.12",
3+
"version": "2.5.13",
44
"appName": "Auth Web",
55
"sbcName": "SBC Common Components",
66
"private": true,

auth-web/src/components/pay/UnlinkedShortNameTable.vue

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
@click="viewDetails(index)"
121121
>
122122
<v-icon small>mdi-format-list-bulleted</v-icon>
123-
<span class="pl-1">View Detail</span>
123+
<span class="pl-1 cursor-pointer">View Detail</span>
124124
</v-list-item-subtitle>
125125
</v-list-item>
126126
</v-list>
@@ -264,7 +264,7 @@ export default defineComponent({
264264
root.$router?.push({
265265
name: 'shortnamedetails',
266266
params: {
267-
'shortNameId': state.results[index].id
267+
'shortNameId': state.results[index].id.toString()
268268
}
269269
})
270270
}
@@ -354,6 +354,14 @@ export default defineComponent({
354354
@import '@/assets/scss/actions.scss';
355355
@import '@/assets/scss/ShortnameTables.scss';
356356
357+
.actions-dropdown_item {
358+
padding: 0.5rem 1rem;
359+
&:hover {
360+
background-color: $gray1;
361+
color: $app-blue !important;
362+
}
363+
}
364+
357365
#unlinked-bank-short-names {
358366
border: 1px solid #e9ecef
359367
}

auth-web/src/components/pay/eft/ShortNameAccountLink.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<template>
22
<v-card v-if="shortNameDetails.shortName">
33
<ShortNameLinkingDialog
4-
:isShortNameLinkingDialogOpen="state.isShortNameLinkingDialogOpen"
4+
:isShortNameLinkingDialogOpen="isShortNameLinkingDialogOpen"
55
:selectedShortName="shortNameDetails"
66
@close-short-name-linking-dialog="closeShortNameLinkingDialog"
77
@on-link-account="onLinkAccount"
@@ -43,7 +43,7 @@
4343
</template>
4444
<script lang="ts">
4545
46-
import { computed, defineComponent, reactive } from '@vue/composition-api'
46+
import { computed, defineComponent, reactive, toRefs } from '@vue/composition-api'
4747
import ConfigHelper from '@/util/config-helper'
4848
import { SessionStorageKeys } from '@/util/constants'
4949
import ShortNameLinkingDialog from '@/components/pay/eft/ShortNameLinkingDialog.vue'
@@ -85,7 +85,7 @@ export default defineComponent({
8585
}
8686
8787
return {
88-
state,
88+
...toRefs(state),
8989
isLinked,
9090
accountDisplayText,
9191
openAccountLinkingDialog,

auth-web/src/components/pay/eft/ShortNameLinkingDialog.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,9 @@ export default defineComponent({
168168
onMounted(async () => {
169169
})
170170
171-
watch(() => props.selectedShortName, (selectedShortNameNewValue) => {
171+
watch(() => [props.selectedShortName, props.isShortNameLinkingDialogOpen], ([selectedShortNameNewValue]) => {
172172
if (props.isShortNameLinkingDialogOpen && selectedShortNameNewValue) {
173-
openAccountLinkingDialog(props.selectedShortName)
173+
openAccountLinkingDialog(selectedShortNameNewValue)
174174
}
175175
})
176176

0 commit comments

Comments
 (0)