Skip to content

Commit 18bb31b

Browse files
authored
refactor + email text field fix (#2854)
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
1 parent 4dda847 commit 18bb31b

File tree

4 files changed

+23
-29
lines changed

4 files changed

+23
-29
lines changed

auth-web/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

auth-web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "auth-web",
3-
"version": "2.6.24",
3+
"version": "2.6.25",
44
"appName": "Auth Web",
55
"sbcName": "SBC Common Components",
66
"private": true,

auth-web/src/views/auth/staff/SafeEmailView.vue

Lines changed: 19 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -52,46 +52,44 @@
5252
</div>
5353
</template>
5454
<script lang="ts">
55-
import { defineComponent, onMounted, ref } from '@vue/composition-api'
55+
import { defineComponent, onMounted, reactive, toRefs } from '@vue/composition-api'
5656
import { SafeEmail } from '@/models/safe-email'
5757
import StaffService from '@/services/staff.services'
5858
5959
export default defineComponent({
6060
name: 'SafeEmailView',
6161
setup () {
62-
const safeEmails = ref<SafeEmail[]>()
63-
const alertMessage = ref('')
64-
const alertType = ref('')
65-
const deletedEmail = ref('')
66-
const delEmailAlertMsg = ref('')
67-
const delEmailAlertType = ref('')
62+
const state = reactive({
63+
safeEmails: [] as SafeEmail[],
64+
alertMessage: '',
65+
alertType: '',
66+
deletedEmail: '',
67+
delEmailAlertMsg: '',
68+
delEmailAlertType: ''
69+
})
6870
6971
function showGeneralAlert (msg: string, type: string) {
70-
alertMessage.value = msg
71-
alertType.value = type
72+
state.alertMessage = msg
73+
state.alertType = type
7274
// 2 seconds timeout
7375
setTimeout(() => {
74-
alertMessage.value = ''
76+
state.alertMessage = ''
7577
}, 2000)
7678
}
7779
7880
function showPerEmailAlert (email: string, type: string) {
79-
deletedEmail.value = email
80-
delEmailAlertType.value = type
81-
if (type === 'success') {
82-
delEmailAlertMsg.value = `Deleted`
83-
} else {
84-
delEmailAlertMsg.value = `Error`
85-
}
81+
state.deletedEmail = email
82+
state.delEmailAlertType = type
83+
state.delEmailAlertMsg = type === 'success' ? 'Deleted' : 'Error'
8684
// 1 seconds timeout
8785
setTimeout(() => {
88-
deletedEmail.value = ''
86+
state.deletedEmail = ''
8987
}, 1000)
9088
}
9189
9290
async function getSafeEmails () {
9391
try {
94-
safeEmails.value = (await StaffService.getSafeEmails()).data
92+
state.safeEmails = (await StaffService.getSafeEmails()).data
9593
} catch (error) {
9694
showGeneralAlert(`Error fetching safe emails, ${error}`, 'error')
9795
}
@@ -114,15 +112,10 @@ export default defineComponent({
114112
})
115113
116114
return {
115+
...toRefs(state),
117116
deleteEmail,
118117
getSafeEmails,
119-
showGeneralAlert,
120-
safeEmails,
121-
alertMessage,
122-
alertType,
123-
deletedEmail,
124-
delEmailAlertMsg,
125-
delEmailAlertType
118+
showGeneralAlert
126119
}
127120
}
128121
})

auth-web/src/views/auth/staff/StaffDashboardView.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -433,6 +433,7 @@ export default defineComponent({
433433
await StaffService.addSafeEmail(safeListEmailsRequestBody)
434434
await safeEmailView.value.getSafeEmails()
435435
safeEmailView.value.showGeneralAlert(`Email ${emailToAdd.value} added successfully`, 'success')
436+
emailToAdd.value = ''
436437
} catch (error) {
437438
// eslint-disable-next-line no-console
438439
const errMsg = `Error adding ${emailToAdd.value}, ${error}`

0 commit comments

Comments
 (0)