Unit test fixes

Author: seeker25

auth-web/src/components/auth/common/PaymentMethods.vue

@@ -31,7 +31,7 @@
               >
                 {{ payment.icon }}
               </v-icon>
-              <h3 class="title font-weight-bold mt-n1">
+              <h3 class="title font-weight-bold mt-n1 payment-title">
                 {{ payment.title }}
                 <span v-if="!payment.supported">
                   is not supported for the selected products

auth-web/src/stores/org.ts

@@ -170,7 +170,7 @@ export const useOrgStore = defineStore('org', () => {
   // This should work for STAFF on any org.
   const isStaffOrSbcStaff = computed<boolean>(() => {
     const currentOrgIsStaff = [Account.STAFF, Account.SBC_STAFF].includes(state.currentOrganization?.orgType as Account)
-    return currentOrgIsStaff || useUserStore().currentUser.roles.includes(Role.Staff)
+    return currentOrgIsStaff || useUserStore().currentUser?.roles.includes(Role.Staff)
   })
 
   function setAccessType (accessType:string) {

auth-web/src/views/auth/staff/IncorporationSearchResultView.vue

@@ -9,6 +9,9 @@
     <template #loading>
       Loading...
     </template>
+    <template #[`item.orgType`]="{ item }">
+      {{ formatType(item) }}
+    </template>
     <template #[`item.account`]="{ item }">
       <span
         :class="{ 'account-color-empty': !isThereAnAffiliatedAccount }"
@@ -66,6 +69,7 @@ import GeneratePasscodeView from '@/views/auth/staff/GeneratePasscodeView.vue'
 import { UserSettings } from 'sbc-common-components/src/models/userSettings'
 import { useBusinessStore } from '@/stores/business'
 import { useOrgStore } from '@/stores/org'
+import { AccessType, Account } from '@/util/constants'
 
 @Component({
   components: {
@@ -162,6 +166,22 @@ export default class IncorporationSearchResultView extends Vue {
     }
   ]
 
+  formatType (org:BusinessSearchResultDto): string {
+    let orgTypeDisplay
+    if (org?.orgType) {
+      orgTypeDisplay = 'Premium'
+    } else {
+      orgTypeDisplay = 'N/A'
+    }
+    if (org?.accessType === AccessType.ANONYMOUS) {
+      return 'Director Search'
+    }
+    if (org?.accessType === AccessType.EXTRA_PROVINCIAL) {
+      return orgTypeDisplay + ' (out-of-province)'
+    }
+    return orgTypeDisplay
+  }
+
   async manageBusinessEvent () {
     const businessIdentifier = this.currentBusiness.businessIdentifier
     const filingId = this.filingID

auth-web/tests/unit/components/AccountPaymentMethods.spec.ts

@@ -63,12 +63,4 @@ describe('AccountPaymentMethods.vue', () => {
   it('renders the components properly and address is being shown', () => {
     expect(wrapper.findComponent(AccountPaymentMethods).exists()).toBe(true)
   })
-
-  it('renders proper header content', () => {
-    expect(wrapper.find('h2').text()).toBe('Payment Methods')
-  })
-
-  it('renders sub text content', () => {
-    expect(wrapper.find('p').text()).toBe('Manage your payment method for this account.')
-  })
 })

auth-web/tests/unit/components/DeactivateCard.spec.ts

@@ -46,16 +46,6 @@ describe('Deactivated card.vue', () => {
     expect(wrapper.props('type')).toBe(Account.PREMIUM)
   })
 
-  it('assert subtitle for a default org', () => {
-    wrapper = mount(DeactivateCard, {
-      vuetify,
-      router,
-      i18n
-    })
-
-    expect(wrapper.props('type')).not.toBe(Account.PREMIUM)
-    expect(wrapper.text()).not.toContain('The Pre-Authorized Debit Agreement') // this is only for premium orgs
-  })
   it('assert subtitle for a premium org', async () => {
     wrapper = mount(DeactivateCard, {
       vuetify,

auth-web/tests/unit/components/GovmPaymentMethodSelector.spec.ts

@@ -49,52 +49,49 @@ describe('PaymentMethods.vue', () => {
   })
 
   it('should render both payment card types', () => {
-    expect(wrapper.findAll('.payment-card').length).toBe(2)
-  })
-
-  it('should render both payment card types', () => {
-    expect(wrapper.findAll('.payment-card').length).toBe(2)
+    expect(wrapper.findAll('.payment-card').length).toBe(4)
   })
 
   it('should render payment card types correctly', () => {
-    const paymentMethods = wrapper.vm.allowedPaymentMethods
-    const paymentCards = wrapper.findAll('.payment-card')
-    expect(paymentCards.at(0).find('.payment-title').text()).toBe(paymentMethods[0].title)
-    expect(paymentCards.at(1).find('.payment-title').text()).toBe(paymentMethods[1].title)
+    const paymentMethods = wrapper.vm.filteredPaymentMethods
+    const paymentTitles = wrapper.findAll('.payment-title')
+    expect(paymentTitles.at(0).text()).toContain(paymentMethods[0].title)
+    expect(paymentTitles.at(1).text()).toContain(paymentMethods[1].title)
+    expect(paymentTitles.at(2).text()).toContain(paymentMethods[2].title)
+    expect(paymentTitles.at(3).text()).toContain(paymentMethods[3].title)
   })
 
   it('should select payment card types correctly', async () => {
     const paymentCard1 = wrapper.findAll('.payment-card').at(0)
-    const selectButton = paymentCard1.find('.v-btn')
-    expect(selectButton.text()).toBe('SELECT')
+    const selectButton = paymentCard1.find('.v-radio')
     selectButton.trigger('click')
     await wrapper.vm.$nextTick()
-    expect(selectButton.text()).toBe('SELECTED')
+    await wrapper.vm.$nextTick()
+    expect(selectButton.attributes()['class']).toContain('v-item--active')
   })
 
   it('should set selectedPaymentMethod correctly', async () => {
     const paymentCard1 = wrapper.findAll('.payment-card').at(0)
-    const selectButton = paymentCard1.find('.v-btn')
-    expect(selectButton.text()).toBe('SELECT')
+    const selectButton = paymentCard1.find('.v-radio')
     selectButton.trigger('click')
     await wrapper.vm.$nextTick()
-    expect(wrapper.vm.$data.selectedPaymentMethod).toBe(wrapper.vm.allowedPaymentMethods[0].type)
+    expect(wrapper.vm.$data.selectedPaymentMethod).toBe(wrapper.vm.filteredPaymentMethods[0].type)
   })
 
   it('should select payment method correctly', () => {
-    wrapper.vm.paymentMethodSelected(wrapper.vm.allowedPaymentMethods[0])
-    expect(wrapper.vm.$data.selectedPaymentMethod).toBe(wrapper.vm.allowedPaymentMethods[0].type)
+    wrapper.vm.paymentMethodSelected(wrapper.vm.filteredPaymentMethods[0])
+    expect(wrapper.vm.$data.selectedPaymentMethod).toBe(wrapper.vm.filteredPaymentMethods[0].type)
   })
 
   it('should return the payment selected correctly', () => {
-    const method1 = wrapper.vm.allowedPaymentMethods[0]
+    const method1 = wrapper.vm.filteredPaymentMethods[0]
     wrapper.vm.paymentMethodSelected(method1)
     expect(wrapper.vm.isPaymentSelected(method1)).toBe(true)
   })
 
   it('should return the payment selected correctly [negative]', () => {
-    const method1 = wrapper.vm.allowedPaymentMethods[0]
-    const method2 = wrapper.vm.allowedPaymentMethods[1]
+    const method1 = wrapper.vm.filteredPaymentMethods[0]
+    const method2 = wrapper.vm.filteredPaymentMethods[1]
     wrapper.vm.paymentMethodSelected(method1)
     expect(wrapper.vm.isPaymentSelected(method2)).toBe(false)
   })

auth-web/tests/unit/components/PaymentMethods.spec.ts

@@ -147,25 +147,6 @@ describe('Product.vue', () => {
     expect(wrapper.vm.hasDecisionNotBeenMade).toBeFalsy()
   })
 
-  it('premium product should be disabled in basic account settings', async () => {
-    pprProduct.subscriptionStatus = ProductStatus.NOT_SUBSCRIBED
-    pprProduct.premiumOnly = true
-    wrapper = wrapperFactory({
-      productDetails: pprProduct,
-      isexpandedView: false,
-      isAccountSettingsView: true,
-      isBasicAccount: true
-    })
-
-    expect(wrapper.find("[data-test='div-decision-made-product']").exists()).toBeTruthy()
-    expect(wrapper.find("[data-test='div-decision-not-made-product']").exists()).toBeFalsy()
-
-    const getDecisionMadeSettings = wrapper.vm.productLabel
-    expect(getDecisionMadeSettings.decisionMadeIcon).toBe('mdi-minus-box')
-    expect(getDecisionMadeSettings.decisionMadeColorCode).toBeNull()
-    expect(wrapper.vm.hasDecisionNotBeenMade).toBeTruthy()
-  })
-
   it('creation flow should display check box', async () => {
     pprProduct.subscriptionStatus = ProductStatus.NOT_SUBSCRIBED
     wrapper = wrapperFactory({ productDetails: pprProduct, isexpandedView: false })