From b29e792e45e8c6fc6f352e43a755c31938d44fc4 Mon Sep 17 00:00:00 2001 From: Travis Semple Date: Mon, 20 Jun 2022 17:20:11 -0700 Subject: [PATCH] 12565 - Logout not clearing Siteminder cookies (#1996) * Adding in SITEMINDER_LOGOUT_URL into configuration.json. * Minor tweaks. * Update sbc-common-components version. --- auth-web/package-lock.json | 14 +++++++------- auth-web/package.json | 2 +- auth-web/public/config/configuration.json | 3 ++- auth-web/src/util/config-helper.ts | 5 +++++ auth-web/src/util/constants.ts | 3 ++- 5 files changed, 17 insertions(+), 10 deletions(-) diff --git a/auth-web/package-lock.json b/auth-web/package-lock.json index d987c2f8a2..11b246fdf5 100644 --- a/auth-web/package-lock.json +++ b/auth-web/package-lock.json @@ -24,7 +24,7 @@ "moment": "^2.24.0", "regenerator-runtime": "^0.13.3", "register-service-worker": "^1.6.2", - "sbc-common-components": "2.4.52", + "sbc-common-components": "2.4.53", "vue": "2.6.12", "vue-i18n": "^8.0.0", "vue-plugin-helper-decorator": "0.0.12", @@ -22245,9 +22245,9 @@ } }, "node_modules/sbc-common-components": { - "version": "2.4.52", - "resolved": "https://registry.npmjs.org/sbc-common-components/-/sbc-common-components-2.4.52.tgz", - "integrity": "sha512-Q7tmhmwjazYnjw4YF02Xe3e539Bkxr8TMzIapiscruqQbNZhXvPi//YOnPsgTcODvSEtCqXGHPRpYPYLrkgjow==", + "version": "2.4.53", + "resolved": "https://registry.npmjs.org/sbc-common-components/-/sbc-common-components-2.4.53.tgz", + "integrity": "sha512-AqEHlyMA+yXJD2fb60kV0UaVyZHsHVQ+NdSkK879z1aNtQYILlRplcOgPUvpVHO4BMik6tDTRrVF1w8ayXcv4g==", "dependencies": { "@mdi/font": "^4.5.95", "axios": "^0.21.1", @@ -44686,9 +44686,9 @@ } }, "sbc-common-components": { - "version": "2.4.52", - "resolved": "https://registry.npmjs.org/sbc-common-components/-/sbc-common-components-2.4.52.tgz", - "integrity": "sha512-Q7tmhmwjazYnjw4YF02Xe3e539Bkxr8TMzIapiscruqQbNZhXvPi//YOnPsgTcODvSEtCqXGHPRpYPYLrkgjow==", + "version": "2.4.53", + "resolved": "https://registry.npmjs.org/sbc-common-components/-/sbc-common-components-2.4.53.tgz", + "integrity": "sha512-AqEHlyMA+yXJD2fb60kV0UaVyZHsHVQ+NdSkK879z1aNtQYILlRplcOgPUvpVHO4BMik6tDTRrVF1w8ayXcv4g==", "requires": { "@mdi/font": "^4.5.95", "axios": "^0.21.1", diff --git a/auth-web/package.json b/auth-web/package.json index c8ff8e3fc4..d4e7037a00 100644 --- a/auth-web/package.json +++ b/auth-web/package.json @@ -30,7 +30,7 @@ "moment": "^2.24.0", "regenerator-runtime": "^0.13.3", "register-service-worker": "^1.6.2", - "sbc-common-components": "2.4.52", + "sbc-common-components": "2.4.53", "vue": "2.6.12", "vue-i18n": "^8.0.0", "vue-plugin-helper-decorator": "0.0.12", diff --git a/auth-web/public/config/configuration.json b/auth-web/public/config/configuration.json index d4bc104524..c863b58172 100644 --- a/auth-web/public/config/configuration.json +++ b/auth-web/public/config/configuration.json @@ -28,5 +28,6 @@ "CORPORATE_ONLINE_URL": "https://dev.corponline.gov.bc.ca/", "FAS_WEB_URL": "https://fas-dev.apps.silver.devops.gov.bc.ca/", "API_DOCUMENTATION_URL": "https://developer.bcregistry.daxiom.ca/apis-summary/", - "PPR_WEB_URL": "https://ppr-ui-dev.apps.silver.devops.gov.bc.ca/ppr/" + "PPR_WEB_URL": "https://ppr-ui-dev.apps.silver.devops.gov.bc.ca/ppr/", + "SITEMINDER_LOGOUT_URL": "https://logontest7.gov.bc.ca/clp-cgi/logoff.cgi" } diff --git a/auth-web/src/util/config-helper.ts b/auth-web/src/util/config-helper.ts index d277d94f41..7f1d08ed6c 100644 --- a/auth-web/src/util/config-helper.ts +++ b/auth-web/src/util/config-helper.ts @@ -21,6 +21,7 @@ export default class ConfigHelper { sessionStorage.setItem(SessionStorageKeys.RegistryHomeUrl, ConfigHelper.getRegistryHomeURL()) sessionStorage.setItem(SessionStorageKeys.NameRequestUrl, ConfigHelper.getNameRequestUrl()) sessionStorage.setItem(SessionStorageKeys.PprWebUrl, ConfigHelper.getPPRWebUrl()) + sessionStorage.setItem(SessionStorageKeys.SiteminderLogoutUrl, ConfigHelper.getSiteminderLogoutUrl()) } /** @@ -134,6 +135,10 @@ export default class ConfigHelper { return ConfigHelper.getValue('PPR_WEB_URL') } + static getSiteminderLogoutUrl () { + return ConfigHelper.getValue('SITEMINDER_LOGOUT_URL') + } + static apiDocumentationUrl () { return ConfigHelper.getValue('API_DOCUMENTATION_URL') } diff --git a/auth-web/src/util/constants.ts b/auth-web/src/util/constants.ts index e91989377e..6fd4d38789 100644 --- a/auth-web/src/util/constants.ts +++ b/auth-web/src/util/constants.ts @@ -19,7 +19,8 @@ export enum SessionStorageKeys { AffidavitNeeded = 'AFFIDAVIT_NEEDED', GOVN_USER='AUTH_GOVN_USER', NameRequestUrl = 'NAME_REQUEST_URL', - PprWebUrl = 'PPR_WEB_URL' + PprWebUrl = 'PPR_WEB_URL', + SiteminderLogoutUrl = 'SITEMINDER_LOGOUT_URL' } export enum Role {