Skip to content

Commit cbd9ee3

Browse files
committed
remove update-env
1 parent dfa4a2e commit cbd9ee3

File tree

1 file changed

+3
-14
lines changed

1 file changed

+3
-14
lines changed

jobs/notebook-report/Makefile

+3-14
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,15 @@ mac-cov: local-test ## Run the coverage report and display in a browser window (
9090
#################################################################################
9191
cd: ## CD flow
9292
ifeq ($(TAG_NAME), test)
93-
cd: update-env
93+
cd:
9494
oc -n "$(OPENSHIFT_REPOSITORY)-tools" tag $(DOCKER_NAME):dev $(DOCKER_NAME):$(TAG_NAME)
9595
else ifeq ($(TAG_NAME), prod)
96-
cd: update-env
96+
cd:
9797
oc -n "$(OPENSHIFT_REPOSITORY)-tools" tag $(DOCKER_NAME):$(TAG_NAME) $(DOCKER_NAME):$(TAG_NAME)-$(shell date +%F)
9898
oc -n "$(OPENSHIFT_REPOSITORY)-tools" tag $(DOCKER_NAME):test $(DOCKER_NAME):$(TAG_NAME)
9999
else
100100
TAG_NAME=dev
101-
cd: build update-env tag
101+
cd: build tag
102102
endif
103103

104104
build: ## Build the docker container
@@ -115,17 +115,6 @@ push: #build ## Push the docker container to the registry & tag latest
115115
docker tag $(DOCKER_NAME) $(REGISTRY_IMAGE):latest ;\
116116
docker push $(REGISTRY_IMAGE):latest
117117

118-
VAULTS=`cat devops/vaults.json`
119-
update-env: ## Update env from 1pass
120-
oc -n "$(OPS_REPOSITORY)-$(TAG_NAME)" exec "dc/vault-service-$(TAG_NAME)" -- ./scripts/1pass.sh \
121-
-m "secret" \
122-
-e "$(TAG_NAME)" \
123-
-a "$(DOCKER_NAME)-$(TAG_NAME)" \
124-
-n "$(OPENSHIFT_REPOSITORY)-$(TAG_NAME)" \
125-
-v "$(VAULTS)" \
126-
-r "false" \
127-
-f "false"
128-
129118
tag: push ## tag image
130119
oc -n "$(OPENSHIFT_REPOSITORY)-tools" tag $(DOCKER_NAME):latest $(DOCKER_NAME):$(TAG_NAME)
131120

0 commit comments

Comments
 (0)