Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions for running option #185

Open
timo-kang opened this issue Oct 28, 2021 · 4 comments
Open

suggestions for running option #185

timo-kang opened this issue Oct 28, 2021 · 4 comments

Comments

@timo-kang
Copy link

Hi, I'm using this network and I think It would be better if there's more options on running network.

  1. init flag
  • if this flag is true, run init_indy_keys.
  • when I specify the IPS argument, I need to change the commented part on von_generate_transactions file.
  1. update initEnv funcion on manage file.
  • I fixed initEnv function since I'm too lazy to put every arguments on a commend when I try to run the network.
  • I've just moved down the part that parses env variables on .env file.
@WadeBarnes
Copy link
Member

@kingworm, Can you provide more details regarding why you feel these additional options are needed?

The basics of running von-network are:
./manage build - Build
./manage start - Start von-network, all initialization is done automatically.
./manage stop - Stop von-network retaining current ledger data and configuration.
./manage down - Stop von-network and delete current ledger data and configuration.

@timo-kang
Copy link
Author

Hi @WadeBarnes,

When I run ./manage start, specifically giving an options with IPS=host1, host2, host3, ..., It causes error something like that it needs to run init_indy_keys. So I uncommented taht part.

the second suggestion is about that when I specify IPS part, for example, initEnv returns IPS="" because parsing an .env file is ahead of parsing a command argument

@Aberasturi
Copy link
Contributor

Hello @kingworm,

I usually use .env file to configure the network or other env variables or key/values without modifing manage script.

for example I have the next ones in my .env file and the genesis file is generated with the IP 192.168.1.34 automatically when i start the network with manage start

IP=192.168.1.34
IPS=192.168.1.34,192.168.1.34,192.168.1.34,192.168.1.34
DOCKERHOST=192.168.1.34
GENESIS_URL=file:///tmp/genesis.txn

Hope this helps.

@timo-kang
Copy link
Author

timo-kang commented Nov 4, 2021

Hello @kingworm,

I usually use .env file to configure the network or other env variables or key/values without modifing manage script.

for example I have the next ones in my .env file and the genesis file is generated with the IP 192.168.1.34 automatically when i start the network with manage start

IP=192.168.1.34
IPS=192.168.1.34,192.168.1.34,192.168.1.34,192.168.1.34
DOCKERHOST=192.168.1.34
GENESIS_URL=file:///tmp/genesis.txn

Hope this helps.

Hello @Aberasturi ,
Thank you for leaving a comment on this issue.

the example that you gave is too obvious one, all IP args are 192.168.1.34.
If you have .env file like

IP=192.168.1.34
IPS=192.168.100.1,192.168.100.11,192.168.100.21,192.168.100.31
GENESIS_URL=file:///tmp/genesis.txn

then when you start the network with manage start,
env variables always returns IP="", IPS=""
since those arguments overwrites over .env file in initEnv function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants