Merge pull request #362 from bearsunday/dot

Suppress warning when dot command not exists

Author: koriym

src/Compiler.php

@@ -120,7 +120,7 @@ public function compile(): int
         printf("Compilation (1/2) took %f seconds and used %fMB of memory\n", $time, $memory);
         printf("Success: %d Failed: %d\n", $this->newInstance->getCompiled(), count($this->newInstance->getFailed()));
         printf("Preload compile: %s\n", $this->dumpAutoload->getFileInfo($preload));
-        printf("Object graph diagram: %s\n", $dot ? realpath($this->dumpAutoload->getFileInfo($dot)) : 'n/a');
+        printf("Object graph diagram: %s\n", realpath($dot));
         foreach ($this->newInstance->getFailed() as $depedencyIndex => $error) {
             printf("UNBOUND: %s for %s \n", $error, $depedencyIndex);
         }

src/Compiler/CompileObjectGraph.php

@@ -31,12 +31,15 @@ public function __invoke(AbstractModule $module): string
         ($this->filePutContents)($dotFile, (new ObjectGrapher())($module));
         $svgFile = str_replace('.dot', '.svg', $dotFile);
         $cmd = "dot -Tsvg {$dotFile} -o {$svgFile}";
-        passthru($cmd, $status);
+        passthru('which dotsrc/Compiler/FakeRun.php 2>/dev/null', $status);
         // @codeCoverageIgnoreStart
         if ($status === 0) {
+            passthru($cmd, $status);
+
             return $svgFile;
         }
 
         return $dotFile;
+        // @codeCoverageIgnoreEnd
     }
 }

src/Compiler/FakeRun.php

@@ -18,7 +18,6 @@
 
 use function assert;
 use function class_exists;
-use function is_callable;
 use function is_object;
 use function ob_end_clean;
 use function ob_start;
@@ -55,8 +54,7 @@ public function __invoke(): void
         $_SERVER['HTTP_IF_NONE_MATCH'] = '0';
         $_SERVER['REQUEST_URI'] = '/';
         $_SERVER['REQUEST_METHOD'] = 'GET';
-        assert(is_callable($bootstrap));
-        /** @psalm-suppress PossiblyUndefinedVariable */
+        /** @psalm-suppress MixedArgumentTypeCoercion */
         ($bootstrap)($this->appMeta->name, $this->context, $GLOBALS, $_SERVER); // 200 OK
         $_SERVER['REQUEST_METHOD'] = 'DELETE';
         $app = $this->injector->getInstance(AppInterface::class);