Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Name "External" only applies to English #10

Open
phoenixr-codes opened this issue Sep 27, 2024 · 1 comment
Open

[🐛 Bug]: Name "External" only applies to English #10

phoenixr-codes opened this issue Sep 27, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@phoenixr-codes
Copy link
Collaborator

The constant NAME can be used to assert a message is not sent by the server itself. However this only works if the client's language is set to English. Thus that constant should be changed to a dictionary that contains the name in all languages (see also: the localization files)

@phoenixr-codes phoenixr-codes added bug Something isn't working good first issue Good for newcomers labels Sep 27, 2024
@phoenixr-codes
Copy link
Collaborator Author

I have extracted the translations:

{
  'nl_NL': 'Extern',
  'fr_CA': 'Externe',
  'it_IT': 'Esterno',
  'nb_NO': 'Ekstern',
  'fi_FI': 'Ulkoinen',
  'en_US': 'Extern',
  'es_ES': 'Externo',
  'ru_RU': 'Внешний',
  'zh_CN': '外部',
  'cs_CZ': 'Externí',
  'da_DK': 'Ekstern',
  'es_MX': 'Externo',
  'th_TW': '外部',
  'bg_BG': 'Външен',
  'uk_UA': 'Зовнішні',
  'sk_SK': 'Externý',
  'pt_PT': 'Exterior',
  'en_GB': 'External',
  'pl_PL': 'Zewnętrzny',
  'sv_SE': 'Extern',
  'tr_TR': 'Harici',
  'id_ID': 'Eksternal',
  'pt_BR': 'Externo',
  'hu_HU': 'Külső',
  'ko_KR': '외부',
  'fr_FR': 'Externe',
  'el_GR': 'Εξωτερικό',
  'de_DE': 'Extern',
  'ja_JP': '外部',
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant