Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about pywhat output order and usability of given matches #232

Open
ghost opened this issue Nov 10, 2021 · 3 comments
Open

Discussion about pywhat output order and usability of given matches #232

ghost opened this issue Nov 10, 2021 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 10, 2021

The regexes clearly have some false positives, so we should improve the output order, add interactive mode or something like that. @bee-san @amadejpapez thoughts?

If you have any ideas or proposals, please post it here.

Originally posted by @piatrashkakanstantinass in #225 (comment)

@bee-san
Copy link
Owner

bee-san commented Nov 11, 2021

I imagine a interactive mode like:

There are 157 results, would you like to only show the top 10?

Would work out quite well. For single items (i.e pywhat text) the higher the rarity, the more likely it should be as it wouldn't have matched. Only showing the top 5% or so would work well.

I haven't given much thought to files though, although the same concept can be applied 😄

@ghost
Copy link
Author

ghost commented Nov 12, 2021

I imagine a interactive mode like:

There are 157 results, would you like to only show the top 10?

Would work out quite well. For single items (i.e pywhat text) the higher the rarity, the more likely it should be as it wouldn't have matched. Only showing the top 5% or so would work well.

I haven't given much thought to files though, although the same concept can be applied 😄

The good question is what should a user do to get the next results or results with a specific tag, name, etc.?

@bee-san
Copy link
Owner

bee-san commented Nov 12, 2021

I wrote a proposal specifically on a Kibana like mode #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant