Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop accepting 100% slippage on strategy swaps #29

Open
sirbeefalot opened this issue Feb 21, 2021 · 0 comments
Open

Stop accepting 100% slippage on strategy swaps #29

sirbeefalot opened this issue Feb 21, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@sirbeefalot
Copy link
Collaborator

Context

Our strategies always send a 0 as amountOutMin when swapping. This means that we're accepting any slippage that the exchange offers.

Problems

This means that our vaults are:

  1. Easier to be exploited by frontrunning bots.
  2. Can burn out a ton of rewards depending on the route.

Solution

  1. Having a healthy default cap on accepted slippage.
  2. Being able to move that cap within a certain range.
@sirbeefalot sirbeefalot added the enhancement New feature or request label Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sirbeefalot