Skip to content

Commit 321064c

Browse files
authored
Merge pull request #1543 from rmartin16/rcedit-2
Upgrade RCEdit from v1.1.1 to v2.0.0
2 parents 694e83c + ea725d6 commit 321064c

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

changes/1543.feature.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
RCEdit v2.0.0 is now used to build Windows apps. Run ``briefcase upgrade`` to use this latest version.

src/briefcase/integrations/rcedit.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class RCEdit(ManagedTool):
1414
@property
1515
def download_url(self) -> str:
1616
return (
17-
"https://github.com/electron/rcedit/releases/download/v1.1.1/rcedit-x64.exe"
17+
"https://github.com/electron/rcedit/releases/download/v2.0.0/rcedit-x64.exe"
1818
)
1919

2020
@property

tests/integrations/rcedit/test_RCEdit__upgrade.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def side_effect_create_mock_appimage(*args, **kwargs):
2626
# A download is invoked
2727
mock_tools.download.file.assert_called_with(
2828
url="https://github.com/electron/rcedit/"
29-
"releases/download/v1.1.1/rcedit-x64.exe",
29+
"releases/download/v2.0.0/rcedit-x64.exe",
3030
download_path=tmp_path / "tools",
3131
role="RCEdit",
3232
)
@@ -60,7 +60,7 @@ def test_upgrade_rcedit_download_failure(mock_tools, rcedit, tmp_path):
6060
# A download was invoked
6161
mock_tools.download.file.assert_called_with(
6262
url="https://github.com/electron/rcedit/"
63-
"releases/download/v1.1.1/rcedit-x64.exe",
63+
"releases/download/v2.0.0/rcedit-x64.exe",
6464
download_path=tmp_path / "tools",
6565
role="RCEdit",
6666
)

tests/integrations/rcedit/test_RCEdit__verify.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def side_effect_create_mock_appimage(*args, **kwargs):
7676
# A download is invoked
7777
mock_tools.download.file.assert_called_with(
7878
url="https://github.com/electron/rcedit/"
79-
"releases/download/v1.1.1/rcedit-x64.exe",
79+
"releases/download/v2.0.0/rcedit-x64.exe",
8080
download_path=tmp_path / "tools",
8181
role="RCEdit",
8282
)
@@ -95,7 +95,7 @@ def test_verify_rcedit_download_failure(mock_tools, tmp_path):
9595
# A download was invoked
9696
mock_tools.download.file.assert_called_with(
9797
url="https://github.com/electron/rcedit/"
98-
"releases/download/v1.1.1/rcedit-x64.exe",
98+
"releases/download/v2.0.0/rcedit-x64.exe",
9999
download_path=tmp_path / "tools",
100100
role="RCEdit",
101101
)

0 commit comments

Comments
 (0)