Initial Setup of Package #1
Conversation
johnzhou721
left a comment
johnzhou721
left a comment
There was a problem hiding this comment.
Some notes on this package.
| extend-select = [ | ||
| "E", # pycodestyle | ||
| "W", # pycodestyle | ||
| "F", # pyflakes | ||
| "UP", # pyupgrade | ||
| "B", # flake8-bugbear | ||
| "YTT", # flake8-2020 | ||
| "ASYNC", # flake8-async | ||
| "C4", # flake8-comprehensions | ||
| "I", # isort | ||
| "RUF", # ruff-specific rules | ||
| "PT", # flake8-pytest-style | ||
| "FURB", # refurb | ||
| "ISC", # flake8-implicit-str-concat | ||
| "PGH", # pygrep-hooks | ||
| "T20", # flake8-print | ||
| "PIE", # flake8-pie | ||
| "SIM", # flake8-simplify | ||
| # The SIM rules are *very* opinionated, and don't necessarily make for better code. | ||
| # They may be worth occasionally turning on just to see if something could actually | ||
| # use improvement. | ||
| # "SIM", # flake8-simplify | ||
| ] |
There was a problem hiding this comment.
FYI -- I updated this list to match the list on Toga, because some of the other rules did weird things like suggesting removing print () statements.
| Source = "https://github.com/beeware/system-pytest6" | ||
| Documentation = "https://system-pyside6.readthedocs.io/en/latest/" | ||
| Tracker = "https://github.com/beeware/system-pyside6/issues" | ||
| Source = "https://github.com/beeware/system-pyside6" |
There was a problem hiding this comment.
Is there an actual related system-pytest6 I've missed here? Let me know if this is not a typo.
| "src/testbed", | ||
| ] | ||
| test_sources = [ | ||
| "../tests", |
There was a problem hiding this comment.
The way this works is that Briefcase integration & normal venv test things are identical; the testbed.py to bootstrap the tests is placed in the root tests/ folder, and in normal operations will not be collected by Pytest.
| [testenv:py] | ||
| dependency_groups = test | ||
| commands = | ||
| python -m pytest tests {posargs:-vv --color yes} |
There was a problem hiding this comment.
Not testing with multiple Python versions here since not all distros can install parallel PySide6s with parallel versions of Python.
There was a problem hiding this comment.
This main file is long -- any suggestions on breaking it up?
There was a problem hiding this comment.
Not sure why this CI isn't running on here... however it's passing over at johnzhou721#1
|
@freakboy3742 I apologize if you simply haven't gotten to this yet, but pinging in case you've missed this (since this is important and it's been 4 days). |
1 participant
Initial setup of Package and CI workflows, in addition to small README and pyproject.toml fixes.
PR Checklist: