From 84ea3c227b50179ddde575e2cffaf7f75bbd615c Mon Sep 17 00:00:00 2001 From: Ben XO <75862+ben-xo@users.noreply.github.com> Date: Tue, 16 May 2023 01:21:31 +0100 Subject: [PATCH 1/2] Added a test to warn that the test suite is invalid against a non-empty default ini --- test/DefaultsTest.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/DefaultsTest.php b/test/DefaultsTest.php index 6e07642..590aea3 100644 --- a/test/DefaultsTest.php +++ b/test/DefaultsTest.php @@ -16,6 +16,14 @@ public static function setUpBeforeClass(): void exec('php dir2cast.php --output=out.xml', self::$output, self::$returncode); } + public function test_default_dir2cast_ini_is_functionally_empty(): void + { + $ini_content = file_get_contents('./dir2cast.ini'); + $this->assertGreaterThan(10000, strlen($ini_content), "ini file is unusually small. If you have edited it, some tests will fail."); + $ini_content = preg_replace("/^(;.*|\s*)\r\n/m", '', $ini_content); + $this->assertEquals("", $ini_content, "ini file is not the default. Some tests may fail."); + } + public function test_default_empty_podcast_creates_output(): void { $this->assertTrue(file_exists(self::$file)); From bf796a236461d7c0e45a39fb06960dfdc8c3a565 Mon Sep 17 00:00:00 2001 From: Ben XO <75862+ben-xo@users.noreply.github.com> Date: Sat, 20 May 2023 00:06:02 +0100 Subject: [PATCH 2/2] Remove 8.3 whilst unstable in GH --- .github/workflows/testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 8254703..43af6b2 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -5,7 +5,7 @@ jobs: strategy: matrix: operating-system: [ubuntu-latest, macos-11] - php-versions: ['7.3', '7.4', '8.0', '8.1', '8.2', '8.3'] + php-versions: ['7.3', '7.4', '8.0', '8.1', '8.2'] runs-on: ${{ matrix.operating-system }} steps: - name: Setup PHP and extensions