-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text editor link highlights are the same color for existant and non-existant links #30
Comments
Ok, I will work on it this week. :) |
@krokofant I got this one fixed by applying the underline style to the |
@bennyxguo That's great! You fixed the live preview issue (which was reported separately), but this issue I assume still exists. <div class="cm-line"><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"><span class="cm-link"><span class="cm-underline">This exists</span></span><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"></div>
<div class="cm-line"><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"><span class="cm-link"><span class="cm-underline">This doesn't exist</span></span><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"><img class="cm-widgetBuffer" aria-hidden="true"><span contenteditable="false"></span><img class="cm-widgetBuffer" aria-hidden="true"></div> <a class="internal-link" data-href="Test document" href="Test document" target="_blank" rel="noopener">This exists</a>
<br>
<a class="internal-link is-unresolved" data-href="Test2" href="Test2" target="_blank" rel="noopener">This doesn't exist</a> I tried doing a quick search on the forum about this but didn't find anything. Edit: Mentioned in the forum |
Thanks for the detail report, let me try it out. |
Title pretty much says it all. In the preview pane, the color for existent and non-existent links are different, as non-existent links show up in a faded grey, whilst existing links have a blue underline if an internal link, or purple underline if external. Yet in editor mode, the same link shows with a blue underline regardless of if the linked note exists or not.
The text was updated successfully, but these errors were encountered: