Skip to content
This repository was archived by the owner on May 10, 2023. It is now read-only.

Commit f538434

Browse files
committed
bump deps, handle DEP0005, make npm audit happy
The "new Buffer(…)" usages have been fixed to non-deprecated "Buffer.from(…)". The npm audit report container a vulnerabiility for a lib that was used by nodeunit – that's why a specific sshpk version is being mentioned in the devDependencies and nodeunit was moved to that section as well. Updated changelog and shrinkwrap file and allowed more engine versions in package file as tests run on all node versions from 4.x up to current edge version of 12.x. refs #138
1 parent c14f7f0 commit f538434

File tree

5 files changed

+2072
-1258
lines changed

5 files changed

+2072
-1258
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,12 @@
33
## 2.7.9 (2019-03-25)
44

55
* fixed: too many folder levels for docker to cope with (see [Issue 138](https://github.com/berlinonline/converjon/issues/138))
6+
* fixed: Usages of ``new Buffer(…)`` have been changed to ``Buffer.from(…)`` – see [DEP0005](https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/) for more info
7+
* bumped node engine version in `package.json` to support more versions – `npm test` succeed for v4.x up to edge v12 atm
8+
* bumped dependencies
9+
* moved `nodeunit` dep into `devDependencies` - it's deprecated and using a specific `sshpk` lib version was necessary to reach `npm audit` result of 0 known vulnerabilities
610

7-
*Beware*: The change of the internal `cache` folder structure means, that your cache is invalidated upon deployment of this version. This shouldn't affect your apps too much as long as you took the hint of running converjon behind a caching reverse proxy. Keep it in mind though when switching to this version as you cache folder size may double.
11+
*Beware*: The change of the internal `cache` folder structure means, that your cache is invalidated upon deployment of this version. This shouldn't affect your apps too much as long as you took the hint of running converjon behind a caching reverse proxy. Keep it in mind though when switching to this version as your cache folder size may double.
812

913
## 2.7.8 (2018-08-02)
1014

lib/pathutils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function replaceAll(string, omit, place, prevstring) {
2424
exports.join = join;
2525

2626
exports.getHashPath = function(input) {
27-
var hash = crypto.createHash('sha256').update(new Buffer(input)).digest("hex");
27+
var hash = crypto.createHash('sha256').update(Buffer.from(input)).digest("hex");
2828
return hash.substr(0, 2)+path_sep+hash;
2929
};
3030

@@ -43,5 +43,5 @@ exports.getOptionsPath = function(options) {
4343
return "__no_options";
4444
}
4545

46-
return crypto.createHash('sha256').update(new Buffer(join(path_parts))).digest("hex");
46+
return crypto.createHash('sha256').update(Buffer.from(join(path_parts))).digest("hex");
4747
};

0 commit comments

Comments
 (0)