Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Insensitivity can also be added into string comparisons #1

Open
bachowsky opened this issue Jun 16, 2023 · 5 comments · May be fixed by #3
Open

Case Insensitivity can also be added into string comparisons #1

bachowsky opened this issue Jun 16, 2023 · 5 comments · May be fixed by #3

Comments

@bachowsky
Copy link

All String comparisons work perfectly with case sensitivity. However, sometimes a customer also needs a string comparison function with case insensitivity. For Example in a case like E-Trade app, the case sensitivity is not important for user, when user wants to filter by a column.

@bachowsky bachowsky changed the title New Feature as equals with case insensitivity Case Insensitivity can also be added into string comparisons Jun 16, 2023
@besimgurbuz
Copy link
Owner

besimgurbuz commented Jun 17, 2023

I agree. Putting another input into MatTableFilterHeader directive to differentiate case sensitivity could be a solution. What do you think? @bachowsky

@bachowsky
Copy link
Author

When I first thought about it, I believed that two types of equality could be included in the list. However, after browsing several e-trade sites, I now think that it would actually be much more effective for the developer to make the decision as input parameter, just like you mentioned.

@besimgurbuz
Copy link
Owner

Ok, would be great to see your contribution as well. What do you say? Would you like to add this functionality?

@bachowsky
Copy link
Author

Sure, I would like to contribute. You can assign me to this feature.

@besimgurbuz
Copy link
Owner

Great, I am waiting for your PR then.

@besimgurbuz besimgurbuz linked a pull request Jul 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants