Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect comments on v_i/ready_o port in bsg_one_fifo #428

Open
muwyse opened this issue Apr 16, 2021 · 3 comments
Open

Incorrect comments on v_i/ready_o port in bsg_one_fifo #428

muwyse opened this issue Apr 16, 2021 · 3 comments

Comments

@muwyse
Copy link
Contributor

muwyse commented Apr 16, 2021

The comments on the v_i/ready_o ports of bsg_one_fifo (

, output ready_o // early
, input [width_p-1:0] data_i // late
, input v_i // late
) incorrectly imply that the interface is ready->valid when in reality the module implements ready&valid.

Adjusting the comments on the data_i and v_i ports to reflect this is a first step. Comments on both should be // early Renaming signals for clarity to v_i, ready_and_o would be ideal in the long term.

@dpetrisko
Copy link
Contributor

// although technically it is okay to just look at v_o

Also, this comment should read v_i, not v_o

@muwyse
Copy link
Contributor Author

muwyse commented Apr 16, 2021

Also, this comment should read v_i, not v_o

However, if we only look at v_i, the interface becomes ready->valid since new data would be captured when the producer raises v_i, regardless of the state of ready_o (i.e., existing data will be cached if the producer does not consider ready_o before raising v_i)

@dpetrisko
Copy link
Contributor

https://github.com/bespoke-silicon-group/basejump_stl/blob/master/bsg_dataflow/bsg_fifo_1r1w_small.v#L25

Yep, we would need to add this parameter to change it

dpetrisko pushed a commit that referenced this issue Jan 26, 2023
* Fixed vcache profiler bugs with re-write

Bugs:
* Order of operations: Python binds or higher than >
* Counting of repeated tags. Previously, only the last tag was counted
* Iteration-order aware tag window

New Features:
* Atomic Misses
* Response Stalls
* More documentation

* Remove deprecated code
* Small field name modifications
* Fixed issue with mismatched tags error
* Fixed issue where TG origin/dim were confused for Device origin/dim
dpetrisko pushed a commit that referenced this issue Jan 26, 2023
* Rewrite Victim Cache Profiler Parser (#428)
* Fixed vcache profiler bugs with re-write
* fix tile parser to get correct min cycle no. for absolute total cycles calculation when using multiple tags (#480)
* Fix header_print_p (for bigblade)

Bugs:
* Order of operations: Python binds or higher than >
* Counting of repeated tags. Previously, only the last tag was counted
* Iteration-order aware tag window

New Features:
* Atomic Misses
* Response Stalls
* More documentation

* Remove deprecated code
* Small field name modifications
* Fixed issue with mismatched tags error
* Fixed issue where TG origin/dim were confused for Device origin/dim


Co-authored-by: Emily Furst <eafurst@cs.washington.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants