-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect comments on v_i/ready_o port in bsg_one_fifo #428
Comments
basejump_stl/bsg_dataflow/bsg_one_fifo.v Line 50 in 7a05961
Also, this comment should read v_i, not v_o |
However, if we only look at v_i, the interface becomes ready->valid since new data would be captured when the producer raises v_i, regardless of the state of ready_o (i.e., existing data will be cached if the producer does not consider ready_o before raising v_i) |
Yep, we would need to add this parameter to change it |
* Fixed vcache profiler bugs with re-write Bugs: * Order of operations: Python binds or higher than > * Counting of repeated tags. Previously, only the last tag was counted * Iteration-order aware tag window New Features: * Atomic Misses * Response Stalls * More documentation * Remove deprecated code * Small field name modifications * Fixed issue with mismatched tags error * Fixed issue where TG origin/dim were confused for Device origin/dim
* Rewrite Victim Cache Profiler Parser (#428) * Fixed vcache profiler bugs with re-write * fix tile parser to get correct min cycle no. for absolute total cycles calculation when using multiple tags (#480) * Fix header_print_p (for bigblade) Bugs: * Order of operations: Python binds or higher than > * Counting of repeated tags. Previously, only the last tag was counted * Iteration-order aware tag window New Features: * Atomic Misses * Response Stalls * More documentation * Remove deprecated code * Small field name modifications * Fixed issue with mismatched tags error * Fixed issue where TG origin/dim were confused for Device origin/dim Co-authored-by: Emily Furst <eafurst@cs.washington.edu>
The comments on the v_i/ready_o ports of bsg_one_fifo (
basejump_stl/bsg_dataflow/bsg_one_fifo.v
Lines 25 to 27 in 7a05961
Adjusting the comments on the data_i and v_i ports to reflect this is a first step. Comments on both should be
// early
Renaming signals for clarity to v_i, ready_and_o would be ideal in the long term.The text was updated successfully, but these errors were encountered: