Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganise Platform Support Dependencies #16877

Open
bushrat011899 opened this issue Dec 18, 2024 · 1 comment
Open

Reorganise Platform Support Dependencies #16877

bushrat011899 opened this issue Dec 18, 2024 · 1 comment
Assignees
@bushrat011899
Labels
A-Cross-Cutting Impacts the entire engine A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Contentious There are nontrivial implications that should be thought through

Comments

@bushrat011899
Copy link
Contributor

bushrat011899 commented Dec 18, 2024 •
edited
Loading

I'm not a fan of how we bring this Instant in. I think it'd be worth considering some kind of bevy_platform_support crate which moves things like spin, portable-atomic, critical-section, wasm-time, etc. into a single spot. It'd be more focussed than bevy_utils, and possibly clean up some of the cfg(...) noise we have across Bevy.

Originally posted by @bushrat011899 in #16874 (comment)
@bushrat011899 bushrat011899 added C-Dependencies A change to the crates that Bevy depends on C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! A-Cross-Cutting Impacts the entire engine D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Dec 18, 2024
@alice-i-cecile alice-i-cecile added X-Contentious There are nontrivial implications that should be thought through A-Utils Utility functions and types labels Dec 18, 2024
@alice-i-cecile
Copy link
Member

Part of #11478.

@bushrat011899 bushrat011899 mentioned this issue Dec 19, 2024
Closed
@bushrat011899 bushrat011899 self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bushrat011899 bushrat011899

Labels
A-Cross-Cutting Impacts the entire engine A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bushrat011899 @alice-i-cecile