Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

For dark themes, the colors become weird in some hinting situations, e.g. when one presses ;p #3

Open
x-ji opened this issue Apr 20, 2020 · 2 comments

Comments

@x-ji
Copy link

x-ji commented Apr 20, 2020

I really like the themes. Though it seems that dark themes sometimes produce weird colors when hinting. An example of what I mean: The tutorial page when I press ;p.

Screenshot 2020-04-20 11 59 40

Another example with Bootstrap buttons with white texts:

Screenshot 2020-04-20 12 01 59

The texts become invisible in such situations.

I'm trying to use the monokai theme.

@RattMoth
Copy link

RattMoth commented Jan 9, 2021

Hey! I just got this extension the other day and ran into this same behavior. I did a little digging, and it looks like any theme that doesn't have a value for --tridactyl-hint-bg will end up looking like the pictures you posted.

For example, I'm using base16-onedark.css right now and I added this line, which seemed to do the trick:
--tridactyl-hint-bg: rgba(40, 44, 52, 0.5) !important;

The color is kind of arbitrary and I'll probably end up changing it around a bit, but I think they key factor is using a darker color with a bit of opacity. Lemme know if this helps! This was the result of only a few minutes of work, so if anyone with extra insight sees this please feel free to correct or verify.

@bezmi
Copy link
Owner

bezmi commented Apr 5, 2021

Hey, I don't really have time to make and test changes as I no longer use tridactyl. If you make any fixes that you think are beneficial for other users, please test and submit a pull request so I can merge them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants