fix "bfe_http : readloop goroutine leak #1209"

xuleiming · xuleiming · commit 0e06df730656 · 2025-01-14T01:25:28.000+08:00
Signed-off-by: xuleiming &lt;xuleiming@yf-networks.com&gt;
diff --git a/bfe_http/transport.go b/bfe_http/transport.go
@@ -885,6 +885,10 @@ func (pc *persistConn) readLoop() {
 			err = ReadRespHeaderError{Err: err}
 		}
 
+		pc.lk.Lock()
+		pc.numExpectedResponses--
+		pc.lk.Unlock()
+
 		rc.ch <- responseAndError{resp, err}
 
 		// Wait for the just-returned response body to be fully consumed
@@ -1051,10 +1055,6 @@ WaitResponse:
 		}
 	}
 
-	pc.lk.Lock()
-	pc.numExpectedResponses--
-	pc.lk.Unlock()
-
 	if re.err != nil {
 		pc.t.setReqConn(req.Request, nil)
 	}

Original file line number	Diff line number	Diff line change
`@@ -885,6 +885,10 @@ func (pc *persistConn) readLoop() {`
`885`	`885`	`err = ReadRespHeaderError{Err: err}`
`886`	`886`	`}`
`887`	`887`
	`888`	`+ pc.lk.Lock()`
	`889`	`+ pc.numExpectedResponses--`
	`890`	`+ pc.lk.Unlock()`
	`891`	`+`
`888`	`892`	`rc.ch <- responseAndError{resp, err}`
`889`	`893`
`890`	`894`	`// Wait for the just-returned response body to be fully consumed`
`@@ -1051,10 +1055,6 @@ WaitResponse:`
`1051`	`1055`	`}`
`1052`	`1056`	`}`
`1053`	`1057`
`1054`		`- pc.lk.Lock()`
`1055`		`- pc.numExpectedResponses--`
`1056`		`- pc.lk.Unlock()`
`1057`		`-`
`1058`	`1058`	`if re.err != nil {`
`1059`	`1059`	`pc.t.setReqConn(req.Request, nil)`
`1060`	`1060`	`}`