Skip to content

Commit 1231903

Browse files
caosjrbia1708
authored andcommitted
spi_engine: Fixup param ranges and CPHA info (analogdevicesinc#1239)
Set validation ranges for DATA_WIDTH and NUM_OF_CS for the expected min/max values in the verilog source code. Also, fix swapped description for CPHA in the documentation. Signed-off-by: Carlos Oliveira <caosjr8@gmail.com>
1 parent 714ec84 commit 1231903

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

docs/library/spi_engine/instruction-format.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,9 @@ bus behavior.
210210
high.
211211
* - [0]
212212
- CPHA
213-
- Configures the phase of the SCLK signal. When 0, data is updated on the
214-
leading edge and sampled on the trailing edge. When 1, data is is
215-
sampled on the leading edge and updated on the trailing edge.
213+
- Configures the phase of the SCLK signal. When 0, data is sampled on the
214+
leading edge and updated on the trailing edge. When 1, data is
215+
sampled on the trailing edge and updated on the leading edge.
216216

217217
.. _spi_engine prescaler-configuration-register:
218218

library/spi_engine/spi_engine_execution/spi_engine_execution_ip.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,15 @@ set cc [ipx::current_core]
6262
set_property -dict [list \
6363
"value_validation_type" "range_long" \
6464
"value_validation_range_minimum" "8" \
65-
"value_validation_range_maximum" "256" \
65+
"value_validation_range_maximum" "32" \
6666
] \
6767
[ipx::get_user_parameters DATA_WIDTH -of_objects $cc]
6868

6969
## NUM_OF_CS
7070
set_property -dict [list \
7171
"value_validation_type" "range_long" \
7272
"value_validation_range_minimum" "1" \
73-
"value_validation_range_maximum" "32" \
73+
"value_validation_range_maximum" "8" \
7474
] \
7575
[ipx::get_user_parameters NUM_OF_CS -of_objects $cc]
7676

0 commit comments

Comments
 (0)