Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Update minimum Python (3.9) and dependencies (SPEC 0 + 1yr) #1092

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Oct 8, 2024

No description provided.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (8a1cf23) to head (a7325bc).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          63       63           
  Lines        7141     7141           
  Branches     1367     1367           
=======================================
  Hits         6411     6411           
  Misses        531      531           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and do SPEC0 + 1yr for the scipy bits.

I think I'll need to make a nibabel release for numpy 2/Python 3.13 support.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Oct 8, 2024

Let's go ahead and do SPEC0 + 1yr for the scipy bits.

sounds good

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
pyproject.toml Outdated Show resolved Hide resolved
@effigies
Copy link
Collaborator

effigies commented Oct 8, 2024

@Remi-Gau We can split out the Python 3.8 drop / minimum dependencies bump from the 3.13 support. Then the 3.13 PR can just be periodically bumped as dependencies add support.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Oct 8, 2024

@Remi-Gau We can split out the Python 3.8 drop / minimum dependencies bump from the 3.13 support. Then the 3.13 PR can just be periodically bumped as dependencies add support.

OK will extract the 3.13 part in a separate PR

@Remi-Gau Remi-Gau changed the title [MAINT] drop support python 3.8 and support python 3.13 [MAINT] drop support python 3.8 Oct 8, 2024
@effigies effigies changed the title [MAINT] drop support python 3.8 [MAINT] Update minimum Python (3.9) and dependencies (SPEC 0 + 1yr) Oct 8, 2024
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when tests pass.

@Remi-Gau Remi-Gau marked this pull request as ready for review October 8, 2024 14:10
@Remi-Gau Remi-Gau merged commit eb2f926 into bids-standard:master Oct 8, 2024
20 checks passed
@Remi-Gau Remi-Gau deleted the maint/3.13 branch October 8, 2024 14:11
@effigies effigies mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants