BC Checkout fixes #2724
Open
BC Checkout fixes #2724
+122
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
tdimambro1
reviewed
Dec 8, 2025
| @@ -41,24 +37,16 @@ export interface LoginFormProps { | |||
| } | |||
|
|
|||
| export interface LoginFormValues { | |||
There was a problem hiding this comment.
can this interface be removed now that it's empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a custom BC checkout experience that is sub optimal. The best practice for custom checkouts is to use the BC "Optimized One Page Checkout" which we are implementing here.
This repo requires a Linux environment to compile the npm build so we are also introducing a Docker container to manage that part. Please check the README.md for more information.