Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to ProjectIrodsFileListAPIView #1996

Open
mikkonie opened this issue Sep 11, 2024 · 0 comments
Open

Add pagination to ProjectIrodsFileListAPIView #1996

mikkonie opened this issue Sep 11, 2024 · 0 comments
Labels
app: samplesheets Issue in the samplesheets app feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Contributor

I left this out of #1994, as it requires a bit further effort and I have more critical things on my TODO list.

This view doesn't contain a queryset nor a serializer. It would be rather trivial to implement a generic paginator such as in this example. Alas, IrodsAPI.get_objects() doesn't currently provide functionality to limit the start of search results. Hence, we would need to query for the entire data set for every result regardless of pagination. Hence the spec below.

Spec

  • Add optional offset to IrodsAPI.get_objects()
  • Add generic list pagination to ProjectIrodsFileListAPIView
  • Update samplesheets API version to v1.1, only enable this for v1.1
  • Add tests
  • Update API documentation

Tagging this for v1.1 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: samplesheets Issue in the samplesheets app feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant