Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer message to sign-in request for WebDAV #2030

Open
Nicolai-vKuegelgen opened this issue Oct 21, 2024 · 1 comment
Open

Add clearer message to sign-in request for WebDAV #2030

Nicolai-vKuegelgen opened this issue Oct 21, 2024 · 1 comment
Labels
cosmetic Cosmetic change, does not affect functionality environment Issues of dependencies, CI, deployment etc.

Comments

@Nicolai-vKuegelgen
Copy link

Nicolai-vKuegelgen commented Oct 21, 2024

Problem

When using the (sometimes very helpful) links to view collection files via WebDAV, there is usually an additional sign-in request from the WebDAV/davrods server. Currently (firefox 131, ubuntu), this request is pop-box with the following information:

sodar.bihealth.org
This site is asking you to sign in.
Username: [ *** ]
Password: [ *** ]

Especially for users not very familiar with Sodar this, seemingly unprompted, sign-in request might be very confusing.

Solution

The popup box should convey additonall information, including the need to add '@org' to the username. I.e.:

sodar.bihealth.org
Browsing files via WebDAv requires a separate login. Please use the same username & password you use for Sodar.
Username: [ *** @ CHARITE ]
Password: [ *** ]

@Nicolai-vKuegelgen Nicolai-vKuegelgen added the feature Requested feature or enhancement label Oct 21, 2024
@mikkonie
Copy link
Contributor

mikkonie commented Oct 22, 2024

As far as I understand, this should be controllable by the DAVRODS_AUTH_NAME env variable provided to davrods-docker. Looking at our Ansible playbook, we in fact have already defined more descriptive login messages there. Why they are currently not showing up, I don't know. I'll look into it.

In any case, this is a ticket for either the Davrods repo or our internal deployment repo, as the SODAR server package does not control login messages for external sites. The exception for this being IGV sessions, which are of course served directly through the Django server.

Still, as this is a valid concern, I'll leave this ticket open until the issue has been handled in the respective components.

It should also be noted that the message should take in account OIDC users if deploying an instance where OIDC is enabled, as a different method of logging in is required for them.

@mikkonie mikkonie added cosmetic Cosmetic change, does not affect functionality environment Issues of dependencies, CI, deployment etc. and removed feature Requested feature or enhancement labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic Cosmetic change, does not affect functionality environment Issues of dependencies, CI, deployment etc.
Projects
None yet
Development

No branches or pull requests

2 participants