Skip to content

Commit 3624d55

Browse files
author
Kurt Gusbeth
committed
Prevent warning
1 parent d61653e commit 3624d55

File tree

5 files changed

+23
-2
lines changed

5 files changed

+23
-2
lines changed

Classes/Controller/LogController.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -630,8 +630,10 @@ public function unsubscribeAction(Log $log = null, int $error = 0): ResponseInte
630630
// default E-Mail holen, falls log noch nicht definiert ist; default email from unsubscribeDMAction
631631
$email = $this->request->hasArgument('defaultEmail') ? $this->request->getArgument('defaultEmail') : '';
632632
if (! $email && $this->settings['parameters']['email']) {
633-
$email = $_GET[$this->settings['parameters']['email']];
634-
if (! $email) {
633+
if (isset($_GET[$this->settings['parameters']['email']])) {
634+
$email = $_GET[$this->settings['parameters']['email']];
635+
}
636+
if (! $email && isset($_POST[$this->settings['parameters']['email']])) {
635637
$email = $_POST[$this->settings['parameters']['email']];
636638
}
637639
}

Documentation/Administrator/Index.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,12 @@ Note
5454
By default the gender and name is used in emails too and thereby the values of the first- and lastname field should be
5555
highlighted as user input in email templates to prevent potential spam-/phishing emails.
5656

57+
Important
58+
~~~~~~~~~
59+
60+
Since version 5.x there is not only one plugin name (pi1). In some cases therefore you need to change the template
61+
and add or delete the pi-parameter at a f:link.external. E.g. at the unsubscribe-page without a verify unsubscribe page.
62+
5763

5864
.. _admin-subscription_form:
5965

Documentation/KnownProblems/Index.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ The domain is missing in the emails when using TYPO3 9? Then you need to add the
1515

1616
The mode dmUnsubscribeMode=1 works only if unsubscribeUid is set.
1717

18+
Since version 5.x there is not only one plugin name (pi1). In some cases therefore you need to change the template
19+
and add or delete the pi-parameter at a f:link.external.
20+
1821
A
1922
`bug tracker <https://github.com/bihor/fp_newsletter/issues>`_
2023
is available for this project at GitHub.

Documentation/Localization.de_DE/Administrator/Index.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,13 @@ Beachte
5656
Standardmässig wird neben der E-Mail-Adresse auch Anrede und Name in den E-Mails verwendet.
5757
Es wird empfohlen, diese zu highlighten, um Spam/Pishing-Emails vorzubeugen.
5858

59+
Wichtig
60+
~~~~~~~
61+
62+
Seit Version 5.x wird nicht nur ein Plugin-Name verwendet. In manchen Fällen muss man deshalb leider die Templates
63+
anpassen und entweder den pi-Parameter hinzufügen oder entfernen! Beispielsweise bei der Abmeldeseite ohne
64+
Verifizierungs-Seite.
65+
5966

6067
.. _admin-Anmeldeformular:
6168

Documentation/Localization.de_DE/KnownProblems/Index.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ Die Domain fehlt in den E-Mails wenn man TYPO3 9 benutzt? Dann muss man die Doma
1515

1616
Der Modus dmUnsubscribeMode=1 funktioniert nur, wenn auch unsubscribeUid gesetzt ist.
1717

18+
Seit Version 5.x wird nicht nur ein Plugin-Name verwendet. In manchen Fällen muss man deshalb leider die Templates
19+
anpassen und entweder den pi-Parameter hinzufügen oder entfernen!
20+
1821
Einen
1922
`Bug-Tracker <https://github.com/bihor/fp_newsletter/issues>`_
2023
für diese Extension findet man bei GitHub.

0 commit comments

Comments
 (0)