Version 7.0.4

Author: bihor

Documentation/ChangeLog/Index.rst

@@ -145,16 +145,20 @@ Version 5.2:
 
 Version 6.0.0:
 - Breaking: support for direct_mail removed. Instead, support for the extension "mail" added.
+
 - Breaking: TypoScript settings dmUnsubscribeMode, module_sys_dmail_html, module_sys_dmail_category renamed to
-  unsubscribeMode, html, categoryOrGroup. See chapter Administrator / Updating to version 6.x.
+unsubscribeMode, html, categoryOrGroup. See chapter Administrator / Updating to version 6.x.
 
 Version 6.1.0:
 - Compatibility to TYPO3 11.5 added again.
+
 - Bugfix: language added to the links in the email.
 
 Version 6.2.0:
 - fe_users can now be used with the extension luxletter or mail.
+
 - deleteMode 3 added: delete only categories (Mail) or user-group (Luxletter).
+
 - New setting: newsletterExtension (mail or luxletter).
 
 Version 6.3.0:
@@ -169,13 +173,21 @@ Version 6.3.2:
 Version 6.4.0:
 - Additional fields can now be copied from the log-entry to the tt_address-table. Setting additionalTtAddressFields added.
 
-Version 7.0.0:
+Version 7.0.0/1:
 - Refactoring with the rector tool.
+
 - Adding of the language code to the email text.
+
 - TypoScript-files have now the ending .typoscript.
+
 - setting dontAppendL is now deprecated.
+
 - Bugfix: search in all folders now for mail-unsubscription and edit too.
 
 Version 7.0.3:
 - Bugfix: backend preview.
-- Bugfix: Plugin-Updater.
+
+- Bugfix: Plugin-Updater.
+
+Version 7.0.4:
+- Unnecessary sql-fields removed.

Documentation/Localization.de_DE/ChangeLog/Index.rst

@@ -143,16 +143,20 @@ Version 5.2:
 
 Version 6.0.0:
 - Breaking: der Support für direct_mail wurde entfernt. Stattdessen wird nun die Extension "mail" unterstützt.
+
 - Breaking: die TypoScript-settings dmUnsubscribeMode, module_sys_dmail_html, module_sys_dmail_category wurden umbenannt zu
-  unsubscribeMode, html, categoryOrGroup. Siehe Kapitel Administrator / Updaten auf version 6.x.
+unsubscribeMode, html, categoryOrGroup. Siehe Kapitel Administrator / Updaten auf version 6.x.
 
 Version 6.1.0:
 - Kompatibilität zu TYPO3 11.5 erneut hinzugefügt.
+
 - Bugfix: Sprache zu den Links in den E-Mails hinzugefügt.
 
 Version 6.2.0:
 - fe_users kann nun mit der Extension Luxletter oder Mail benutzt werden.
+
 - deleteMode 3 hinzugefügt: lösche nur Kategorien (Mail) oder Benutzergruppe (Luxletter).
+
 - Neue Einstellungsmöglichkeit: newsletterExtension (mail oder luxletter).
 
 Version 6.3.0:
@@ -167,13 +171,21 @@ Version 6.3.2:
 Version 6.4.0:
 - Zusätzliche Felder können nun aus dem Log-Eintrag in eine tt_address-Tabelle kopiert werden. Setting additionalTtAddressFields hinzugefügt.
 
-Version 7.0.1:
+Version 7.0.0/1:
 - Refactoring mit dem rector-Tool.
+
 - Der Sprach-Code wird nun bei f:translate in den E-Mail-Templates hinzugefügt.
+
 - TypoScript-Dateien haben nun die Endung .typoscript.
+
 - Die setting dontAppendL ist nun deprecated.
+
 - Bugfix: Suche in allen Ordners greift nun öfters.
 
 Version 7.0.3:
 - Bugfix: Backend-Vorschau.
-- Bugfix: Plugin-Updater.
+
+- Bugfix: Plugin-Updater.
+
+Version 7.0.4:
+- Unnötige SQL-Felder entfernt.

README.md

@@ -1,6 +1,6 @@
 # fp_newsletter
 
-Version 7.0.3
+Version 7.0.4
 
 The TYPO3 extension fp_newsletter is designed to provide a newsletter subscription and unsubscription service for the 
 table tt_address which can be used by the extension mail OR for the table fe_users which can be used by luxletter or mail. 
@@ -26,4 +26,7 @@ Version 7.0.0/1:
 
 Version 7.0.2/3:
 - Bugfix: backend preview.
-- Bugfix: Plugin-Updater.
+- Bugfix: Plugin-Updater.
+
+Version 7.0.4:
+- Unnecessary sql-fields removed.

Tests/Unit/Controller/LogControllerTest.php

@@ -1,9 +1,11 @@
 <?php
 namespace Fixpunkt\FpNewsletter\Tests\Unit\Controller;
 
-use TYPO3\CMS\Core\Tests\UnitTestCase;
+use PHPUnit\Framework\MockObject\MockObject;
+use TYPO3\TestingFramework\Core\AccessibleObjectInterface;
+use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
+use TYPO3Fluid\Fluid\View\ViewInterface;
 use Fixpunkt\FpNewsletter\Controller\LogController;
-use TYPO3\CMS\Extbase\Persistence\ObjectStorage;
 use Fixpunkt\FpNewsletter\Domain\Repository\LogRepository;
 use Fixpunkt\FpNewsletter\Domain\Model\Log;
 /**
@@ -28,6 +30,7 @@ protected function setUp()
 
     protected function tearDown()
     {
+        parent::tearDown();
     }
 
     /**
@@ -41,18 +44,16 @@ public function listActionFetchesAllLogsFromRepositoryAndAssignsThemToView()
             ->getMock();
 
         $logRepository = $this->getMockBuilder(LogRepository::class)
-            ->setMethods(['findAll'])
+            ->onlyMethods(['findAll'])
             ->disableOriginalConstructor()
             ->getMock();
         $logRepository->expects(self::once())->method('findAll')->will(self::returnValue($allLogs));
-        $this->inject($this->subject, 'logRepository', $logRepository);
+        $this->subject->_set('logRepository', $logRepository);
 
-        // TODO
-        /*
-        $view = $this->getMockBuilder(\TYPO3\CMS\Extbase\Mvc\View\ViewInterface::class)->getMock();
+        $view = $this->getMockBuilder(ViewInterface::class)->getMock();
         $view->expects(self::once())->method('assign')->with('logs', $allLogs);
-        $this->inject($this->subject, 'view', $view);
-        */
+        $this->subject->_set('view', $view);
+
         $this->subject->listAction();
     }
 

ext_emconf.php

@@ -17,7 +17,7 @@
     'author' => 'Kurt Gusbeth',
     'author_company' => 'fixpunkt für digitales GmbH',
     'state' => 'stable',
-    'version' => '7.0.3',
+    'version' => '7.0.4',
     'constraints' => [
         'depends' => [
         	'typo3' => '11.5.0-12.4.99'

ext_tables.sql

@@ -3,9 +3,6 @@
 #
 CREATE TABLE tx_fpnewsletter_domain_model_log (
 
-	uid int(11) DEFAULT '0' NOT NULL auto_increment,
-	pid int(11) DEFAULT '0' NOT NULL,
-
 	gender int(11) DEFAULT '0' NOT NULL,
 	title varchar(255) DEFAULT '' NOT NULL,
 	firstname varchar(255) DEFAULT '' NOT NULL,
@@ -28,22 +25,6 @@ CREATE TABLE tx_fpnewsletter_domain_model_log (
 	www varchar(255) DEFAULT '' NOT NULL,
 	position varchar(255) DEFAULT '' NOT NULL,
 	company varchar(255) DEFAULT '' NOT NULL,
-	categories varchar(255) DEFAULT '' NOT NULL,
-
-	tstamp int(11) unsigned DEFAULT '0' NOT NULL,
-	crdate int(11) unsigned DEFAULT '0' NOT NULL,
-	cruser_id int(11) unsigned DEFAULT '0' NOT NULL,
-	deleted tinyint(4) unsigned DEFAULT '0' NOT NULL,
-	hidden tinyint(4) unsigned DEFAULT '0' NOT NULL,
-
-	sys_language_uid int(11) DEFAULT '0' NOT NULL,
-	l10n_parent int(11) DEFAULT '0' NOT NULL,
-	l10n_diffsource mediumblob,
-
-	PRIMARY KEY (uid),
-	KEY parent (pid),
-	KEY language (l10n_parent,sys_language_uid)
-
-);
+	categories varchar(255) DEFAULT '' NOT NULL
 
-## EXTENSION BUILDER DEFAULTS END TOKEN - Everything BEFORE this line is overwritten with the defaults of the extension builder
+);