Skip to content

fix(utility): Support downloading trading instruments with Chinese names #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chappie2054 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(utility): Support downloading trading instruments with Chinese names #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/utility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from pathlib import Path
from datetime import *
import urllib.request
from urllib.parse import quote
from argparse import ArgumentParser, RawTextHelpFormatter, ArgumentTypeError
from enums import *

Expand All @@ -15,7 +16,9 @@ def get_destination_dir(file_url, folder=None):
return os.path.join(store_directory, file_url)

def get_download_url(file_url):
return "{}{}".format(BASE_URL, file_url)
# Ensure the URL is properly encoded to handle Chinese characters
encoded_url = quote(file_url, safe='/')
return "{}{}".format(BASE_URL, encoded_url)

def get_all_symbols(type):
if type == 'um':
Expand Down