Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Fets for API #48

Open
Ashraf-Ali-aa opened this issue Apr 11, 2024 · 3 comments
Open

Add support for Fets for API #48

Ashraf-Ali-aa opened this issue Apr 11, 2024 · 3 comments
Labels
question Further information is requested

Comments

@Ashraf-Ali-aa
Copy link

Start Date

No response

Implementation PR

No response

Reference Issues

No response

Summary

use https://github.com/ardatan/feTS for API client

Basic Example

check the website

Drawbacks

require open API spec

Unresolved questions

No response

@Ashraf-Ali-aa Ashraf-Ali-aa added the question Further information is requested label Apr 11, 2024
@MateuszRostkowski
Copy link
Collaborator

@Ashraf-Ali-aa
We are using axios for api calls. It's deeply integrated into our logic and it will be hard to replace it with feTS.

Right now we don't plan to change axios to any other library but feel free to create your implementation. You can create fork and create pull request with your suggested changes.

@Ashraf-Ali-aa
Copy link
Author

Ashraf-Ali-aa commented Apr 12, 2024

ok, thanks, you can use axois with Fets, this tool replaces the code generation part for getting API type safety in TS, it generates types at build time so no code is generated

https://the-guild.dev/openapi/fets/client/quick-start

https://the-guild.dev/openapi/fets/client/client-configuration

@MateuszRostkowski
Copy link
Collaborator

I looks good, but I think it will not easy for that, we would also need to do some changes on the backend side, and now we don't have capacity to do that. But I will leave this issue open and maybe in near future we will try to implement it 🙂

Thanks for your suggestions ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants