Merge pull request #60 from biscuit-auth/test-clap

Test command-line parsing configuration

Author: divarvel

.github/workflows/rust.yml

@@ -15,8 +15,6 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: mig4/setup-bats@v1
-    - uses: brokenpip3/setup-bats-libs@0.1.0
     - uses: actions/checkout@v2
     - name: Cache
       uses: actions/cache@v2
@@ -36,4 +34,3 @@ jobs:
     - name: Tests
       run: |
         cargo test
-        bats test.bats

README.md

@@ -145,21 +145,3 @@ cargo fmt --check
 # CI ensures that there are no outstanding clippy hints
 cargo clippy
 ```
-
-### Integration tests
-
-To run integration tests locally, you will need `bats`. For now, only installation through `brew` and github actions is supported (`bats` needs to load its modules manually, and their installation path depends how they were installed). Feel free to add support for more systems as needed.
-
-```sh
-bats test.bats
-```
-
-<details>
-<summary>Installation with brew</summary>
-```sh
-brew install bats-core
-brew tap kaos/shell
-brew install bats-assert
-brew install bats-file
-```
-</details>

src/cli.rs

@@ -351,3 +351,9 @@ mod common_args {
         pub raw_input: bool,
     }
 }
+
+#[test]
+fn verify_cli() {
+    use clap::CommandFactory;
+    Opts::command().debug_assert();
+}

src/inspect.rs

@@ -414,7 +414,7 @@ pub fn handle_inspect_inner(inspect: &Inspect) -> Result<InspectionResults> {
 
     if let Some(key_from) = public_key_from {
         let key = read_public_key_from(&key_from)?;
-        let sig_result = biscuit.check_signature(|_| key);
+        let sig_result = biscuit.verify(key);
         signatures_check = Some(sig_result.is_ok());
 
         if let Ok(biscuit) = sig_result {