Merge pull request #3266 from axpoems/handle-null-values-isNotificationPanelVisible

Add null check for isNotificationPanelVisible

Author: axpoems

apps/desktop/desktop/src/main/java/bisq/desktop/main/alert/AlertBannerController.java

@@ -49,8 +49,11 @@ public AlertBannerController(ServiceProvider serviceProvider) {
     @Override
     public void onActivate() {
         unconsumedAlertsPin = alertNotificationsService.getUnconsumedAlerts().addObserver(this::showAlertBanner);
-        isBisqEasyNotificationVisiblePin = bisqEasyNotificationsService.getIsNotificationPanelVisible().addObserver(
-                this::updateIsBisqEasyNotificationVisible);
+        isBisqEasyNotificationVisiblePin = bisqEasyNotificationsService.getIsNotificationPanelVisible().addObserver(isVisible -> {
+            if (isVisible != null) {
+                updateIsBisqEasyNotificationVisible(isVisible);
+            }
+        });
     }
 
     @Override

apps/desktop/desktop/src/main/java/bisq/desktop/main/alert/AlertBannerModel.java

@@ -32,7 +32,7 @@ public class AlertBannerModel implements Model {
     private final StringProperty headline = new SimpleStringProperty();
     private final StringProperty message = new SimpleStringProperty();
     private final ObjectProperty<AlertType> alertType = new SimpleObjectProperty<>();
-    private final BooleanProperty isBisqEasyNotificationVisible = new SimpleBooleanProperty();
+    private final BooleanProperty isBisqEasyNotificationVisible = new SimpleBooleanProperty(false);
 
     public AlertBannerModel() {
     }

apps/desktop/desktop/src/main/java/bisq/desktop/main/content/ContentTabController.java

@@ -22,6 +22,7 @@
 import bisq.bonded_roles.security_manager.alert.AlertNotificationsService;
 import bisq.common.observable.Pin;
 import bisq.desktop.ServiceProvider;
+import bisq.desktop.common.threading.UIThread;
 import bisq.desktop.common.view.TabController;
 import lombok.extern.slf4j.Slf4j;
 
@@ -57,8 +58,12 @@ public void onDeactivate() {
     }
 
     private void updateIsNotificationVisible() {
-        model.getIsNotificationVisible().set(
-                bisqEasyNotificationsService.getIsNotificationPanelVisible().get()
-                        || alertNotificationsService.getIsAlertBannerVisible().get());
+        UIThread.run(() -> {
+            boolean isNotificationPanelVisible = bisqEasyNotificationsService.getIsNotificationPanelVisible() != null
+                    && bisqEasyNotificationsService.getIsNotificationPanelVisible().get();
+            boolean isAlertBannerVisible = alertNotificationsService.getIsAlertBannerVisible() != null
+                    && alertNotificationsService.getIsAlertBannerVisible().get();
+            model.getIsNotificationVisible().set(isNotificationPanelVisible || isAlertBannerVisible);
+        });
     }
 }