Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider migrating tests to Nightmare or other headless browser #10

Open
imaustink opened this issue May 2, 2017 · 2 comments
Open

Consider migrating tests to Nightmare or other headless browser #10

imaustink opened this issue May 2, 2017 · 2 comments

Comments

@imaustink
Copy link
Contributor

Zombie isn't terrible but it's built on top of jsdom and thus has a limited implementation of the DOM. For certain tests, we have to make exceptions for Zombie and bypass functionality. In my opinion this is ugly and wrong. Not to mention the fact that you can't inspect code running in the Zombie browser, making debugging a real pain.

I'm not certain Nightmare can fix all of this, but I am confident it will fix some of our problems. I think it would be wise to investigate further.
@leoj3n
Copy link
Contributor

leoj3n commented May 2, 2017

Specifically, we should try using it with a test that was failing with a version of steal before that fix for zombie was made, and also see if it supports dataset unlike zombie.

@leoj3n
Copy link
Contributor

leoj3n commented May 3, 2017 •
edited
Loading

https://developers.google.com/web/updates/2017/04/headless-chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leoj3n @imaustink