Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectMaker 2.0 #53

Closed
wants to merge 3 commits into from
Closed

ProjectMaker 2.0 #53

wants to merge 3 commits into from

Conversation

pykong
Copy link
Collaborator

@pykong pykong commented Mar 19, 2018 •
edited
Loading

Work in progress.
Not merge ready

Project got major overhaul and much cruft was removed.
Yet, token replacement is currently broken.

TODO:

  • outsource templating to an external package, to simplify code base
  • update README
  • add message
  • include proper semantic versioning
  • if possible include resumeback as a dependency
  • add proper typing
  • replace providedsample-templates with a command to open: https://github.com/bit101/STProjectMaker-templates
  • templating:
    • decide on default template tags: ${ } vs {{ }}
    • consider .sublime-options file instead of voodoo.json
    • tasks.json and variable file should not be copied
    • decide on whether to allow to pull templates from url
    • check what could be done in order to enhance backwards compatibility
  • voodoo related:
    • parent templates should not be copied
    • variable file should support both defining and prompting for variables

Fixes: #44
Fixes: #52
Fixes: #56

@pykong pykong mentioned this pull request Mar 19, 2018
Closed
pykong
pykong commented Mar 19, 2018
View reviewed changes
project_maker.py Outdated
# somehow can not use self.window here
sublime.active_window().run_command(target, cmd_args)

def open_project_window(self):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@audinue You may want to have a look here. And transfer changes from your recent PR into this method.
I only implemented your suggested changes as far as I grasped them.

@pykong pykong mentioned this pull request Mar 21, 2018
Closed
@pykong pykong changed the title WIP - Major refactoring. ProjectMaker 2.0 Mar 25, 2018
@pykong pykong mentioned this pull request Apr 1, 2018
Closed
@pykong
Copy link
Collaborator Author

pykong commented Feb 24, 2020

Closing as I am no longer proceeding with this PR.

@pykong pykong closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove keybindings Don't open Finder when creating a new project? Consider integrating template engine
1 participant
@pykong