dustThreshold in finalize - different for segwit?

[karelbilek]

Should dustThreshold in utils.js be different for segwit changes, or not?

[dcousens]

Did it change in bitcoin core?

[karelbilek]

It seems so

https://github.com/bitcoin/bitcoin/blob/f90603ac6d24f5263649675d51233f1fce8b2ecd/src/policy/policy.cpp#L20

Also it is counted a little differently than it is calculated in this repo anyway.

However, dustRelayFee is not the "current fee", but it is pre-set here, as 1sat/b (and is a user option)

https://github.com/bitcoin/bitcoin/blob/08a7316c144f9f2516db8fa62400893f4358c5ae/src/policy/policy.h#L48

Dust in this repo is, however, not meant as "dust" as in "what are standard transactions", but as in "what is the minimal change that I will create", and that is defined in core in wallet.h as MIN_CHANGE as CENT = 1000000 sat, and fee or segwit is irrelevant (and is also user configurable)

see wallet.h and wallet.cpp