Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the package.json dependencies #27

Open
2 tasks
chasenlehara opened this issue Jun 6, 2016 · 5 comments
Open
2 tasks

Fix the package.json dependencies #27

chasenlehara opened this issue Jun 6, 2016 · 5 comments

Comments

@chasenlehara
Copy link
Contributor

  • can should also be in peerDependencies
  • cssify should be moved to devDependencies
@justinbmeyer
Copy link

Can should probably be a straight dependency. peerDependencies are deprecated. Also, you can make SEMVER point at every supported CanJS version.

Before moving cssify, I'd make sure browserify apps work without it. If I remember correctly, it's needed.

@leoj3n
Copy link

leoj3n commented Jun 9, 2016

Here is a good, quick read on the deprecation of peerDependencies.

Related to the necessity of browserify-specific configuration in package.json:

donejs/generator-donejs#134

Feels bad to make all CanJS plugins depend on cssify, just to be compatible with browserify. I wonder if it's really necessary; but I've never used browserify, so I'm not really sure where to begin testing.

Is there an issue from where the idea of having to include cssify as a dependency originated? Maybe it's not actually necessary, or there is better way of adding browserify support. My understanding is browserify should work with most any NPM package, without special modifications.

@justinbmeyer
Copy link

@leoj3n it's only necessary for plugins that load CSS.

@leoj3n
Copy link

leoj3n commented Mar 6, 2017

@chasenlehara I think this issue can be closed now?

@chasenlehara
Copy link
Contributor Author

chasenlehara commented Mar 6, 2017

I don’t think this can be closed. I moved can to devDependencies; I think Justin is right that it shouldn’t be in peerDependencies, but I’m unsure whether it should be in dependencies.

cssify is still listed in dependencies so that hasn’t been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants