Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Navigator push a new page, the root page's window buttons disappears #131

Open
sleepreading opened this issue Feb 9, 2022 · 7 comments

Comments

@sleepreading
Copy link

We usually add window button (minimized button, maximized button ..) to the root page. and hope these buttons work like the windows title bar (never disappears).
But if we Navigator.of(context).push() a new page, this page will have no these buttons. By the way, add this code

Column(
        children: [
          WindowTitleBarBox(
            child: Row(
              children: [
                Expanded(child: MoveWindow()),
                windowButtons,
              ],
            ),
          ),
          Expanded(child: mainBody),  // <-- the real content
        ],
      )

to every page is really redundant.

@kekavc24
Copy link

kekavc24 commented Nov 19, 2022

Hey @sleepreading. Can you add code from main.dart file. I wanna see how you handle navigation. Then suggest a workaround that worked for me.

@bitsdojo
Copy link
Owner

I somehow missed this question but this is a great idea and I should add an example app that uses navigation.

@kekavc24
Copy link

kekavc24 commented Nov 19, 2022

@bitsdojo Can I create one with a simple onGenerateRoute and create a PR for flutter windows?

@bitsdojo
Copy link
Owner

Sounds good!

I was wondering if anyone would be interested in an example using go_router?

@kekavc24
Copy link

Why not? 😅 Someone will want to use it with go_router. It's always great to tackle every avenue IMO!

@kekavc24
Copy link

@bitsdojo #206 done here

@Mamasodikov
Copy link

It really sucks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants