Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSIP-0043 further improvements: share taker market fees to maker's registrar and referrer #192

Closed
bitphage opened this issue Aug 16, 2019 · 3 comments

Comments

@bitphage
Copy link

Current implementation always rewards buyer of the asset (referrer and registrar) no matter was he is_maker: True or False. Instead, it would be more reasonable to always reward Maker.

Example (current): maker keeps sell order of 1000 CNY (order stays on books). When order fills, reward will go to buyer.
Proposed change: when order fills, the reward goes to Maker.

@abitmore
Copy link
Member

abitmore commented Aug 16, 2019

The logic about market fee sharing is: the one who bought an amount of asset pays the market fee, her registrar and referrer would get a part of the fee. It's fair to reward the parties because they brought the trader who paid the fees. The logic was clear.

I don't think it's good to mix maker-taker incentives with market fee sharing incentives. For incentives about market makers, I think it's better to discuss in the scope of #130 (or the PR #133).

@pmconrad
Copy link
Contributor

the one who bought an amount of asset pays the market fee

Clarification: in every trade there are two buyers, and both pay a market fee on the asset they buy (provided that the asset has a market fee set).

@pmconrad
Copy link
Contributor

Agree that maker/taker fees are already discussed elsewhere. Closing this as a duplicate.

@abitmore abitmore changed the title BSIP-0043 further improvements BSIP-0043 further improvements: share taker market fees to maker's registrar and referrer Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants