Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OsmSharp's Data Model #4

Closed
blackboxlogic opened this issue Aug 5, 2019 · 7 comments
Closed

Fix OsmSharp's Data Model #4

blackboxlogic opened this issue Aug 5, 2019 · 7 comments
Assignees

Comments

@blackboxlogic
Copy link
Owner

blackboxlogic commented Aug 5, 2019

I'm fixing up OsmSharp's handling of xml responses.
OsmSharp/core#80
OsmSharp/core#78
OsmSharp/core#76

@blackboxlogic blackboxlogic self-assigned this Aug 5, 2019
@blackboxlogic blackboxlogic changed the title Fix OsmSharp's Xml Handling Fix OsmSharp's Data Model Aug 6, 2019
@blackboxlogic
Copy link
Owner Author

I think I've made all the changes that need to be made in the OsmSharp data model. If they don't want to merge the pull requests then I guess we're forking OsmSharp. TBD.

@blackboxlogic
Copy link
Owner Author

We still need to reference OsmSharp's nuget package, instead of including a fork of their sub-repo.
Waiting for merge of OsmSharp/core#82

@blackboxlogic
Copy link
Owner Author

blackboxlogic commented Aug 17, 2019

Also, looking like we're still missing

  • Dictionary<string, string> User.Preferences
  • Track[] GpxFile.Tracks
  • string Track.Name
  • string Track.Description
  • string Track.URL
  • TrackSegment[] Track.TrackSegments
  • TrackPoint[] TrackSegment.TrackPoints
  • long? TrackPoint.Latitude
  • long? TrackPoint.Longitude
  • DateTime TrackPoint.Time

@HarelM
Copy link
Collaborator

HarelM commented Aug 17, 2019

Gpx file scheme, reader and writer can be taken from NTS.IO.GPX.
Which API method does the track belongs to? Wouldn't it be enough to use stream?

@blackboxlogic
Copy link
Owner Author

So... the data that comes back from
GET /api/0.6/trackpoints?bbox=left,bottom,right,top&page=pageNumber
is gpx version 1.0
and NetTopologySuite/NetTopologySuite.IO.GPX#35

I've made openstreetmap/openstreetmap-website#2350 but I'll probably not be able to use NTS.IO.GPX

@blackboxlogic
Copy link
Owner Author

After doing the work, I now see that just returning a stream is the right answer for both calls that get gpx data. Thanks for trying to save me the effort.

@blackboxlogic
Copy link
Owner Author

All major changes to OsmSharp are done. The data model now supports all calls to the API. Any further changes will be minor fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants