Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Notion Publisher #223

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

britton-from-notion
Copy link

Changes

  • adds Notion publisher plugin
  • adds markdown glob data source
  • adds Notion plugin to validator test

Notes

This is a really rough first pass at the Notion publisher. I have not run this, it's really just the general layout of the code. Will make some more iterations of this but putting up the draft PR to share the work as I go and take any feedback!

fixes #221

@traut
Copy link
Member

traut commented Aug 2, 2024

nice start! We have some changes coming in the next couple of days, which would require adjustments in your draft.

for the data source -- I think we can consolidate it under the existing txt data source. We make it generic by renaming it into text_file and adjusting the docs to note that it supports text, markdown, etc

@brittonhayes
Copy link

Sounds good! I'll hold off changes for a bit and keep dialing in the upstream markdown to blocks converter until that breaking change comes out.

@traut
Copy link
Member

traut commented Aug 17, 2024

@brittonhayes just a ping that the recent big refactoring was merged in!

@brittonhayes
Copy link

Awesome! Thanks for the ping @traut

I'll set aside some time to checkout the new changes and get this feature all wrapped up ✔️

@britton-from-notion britton-from-notion marked this pull request as ready for review August 24, 2024 23:26
@britton-from-notion
Copy link
Author

Hey again @traut! I got all the conflicts sorted out. Currently at a spot where I'm unsure how to test the publisher since it requires installing the plugin from the registry but the plugin is only present locally.

Also thinking it would probably make sense for this publisher to support some of the builtin content providers like title, codeblock, list, text, blockquote etc; however the built-in content providers are not exported from the builtin/ package. Would it be possible to export the functions such as builtin.makeCodeContentProvider?

@traut
Copy link
Member

traut commented Sep 28, 2024

@britton-from-notion, I'm sorry for the huge delay here. We're working on a heavy refactoring that changes how we handle formatting/publishing in Fabric (see #239). The goal is to detach the internal data model from Markdown, allowing us to support more formats (better HTML and PDF) and more publishers (allowing publisher-specific formatting suitable for Notion, for example). We hope to get the code in in the next week, and I'll be happy to help adjust your code to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notion Publisher
3 participants