Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to manual refetch table #98

Closed
wants to merge 1 commit into from
Closed

Conversation

luizakp
Copy link
Contributor

@luizakp luizakp commented Sep 20, 2024

This PR adds possibility to manual refetch table

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bleu-ui ❌ Failed (Inspect) Sep 20, 2024 5:34pm

fetchPath,
initialSearch
);

React.useEffect(() => {
mutate();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case we are doing the request 2 times on mount, right?

Copy link
Contributor

@devjoaov devjoaov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I see here, it seems that we do a request on the first render. i would double check this and only perform the mutate after the component mount

@luizakp
Copy link
Contributor Author

luizakp commented Sep 25, 2024

no need for this according to this implementation: https://github.com/bleu/perksocial-rails/pull/736/commits/809736c64c37d5d56d01c6db7837874988c3683d

@luizakp luizakp closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants