Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Error When ENV vars are set via Runpod Template #64

Open
jelling opened this issue Sep 7, 2024 · 1 comment
Open

Type Error When ENV vars are set via Runpod Template #64

jelling opened this issue Sep 7, 2024 · 1 comment

Comments

@jelling
Copy link

jelling commented Sep 7, 2024

time.sleep(COMFY_POLLING_INTERVAL_MS / 1000)

When defining a template on Runpod, there is an option to manually set environment variables. These variables seem to be interpolated as strings at run-time. That causes this division statement to fail as it can't divide a string.

Apologies for not PR'ing the fix for here and other places, but I've got a fork and then a subtree from that and I don't have my tooling setup well yet.

@mikedegeofroy
Copy link

mikedegeofroy commented Oct 26, 2024

I've just faced the same issue, when setting COMFY_POLLING_MAX_RETRIES

try:
while retries < COMFY_POLLING_MAX_RETRIES:
history = get_history(prompt_id)

Error waiting for image generation: '<' not supported between instances of 'int' and 'str'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants