-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with recent typescript changes #13
Comments
The type issues are not specific to Bun, types used in exported BlinkDB methods should be exported as well. Oversight on my part. I'll try and see if I can resolve the BTree issue. |
Found the cause. BlinkDB uses a (And apparently BlinkDB types like I've pushed up a new version of BlinkDB that fixes these issues, and which works for your repository on my local machine. Can you verify on your end? |
@froehlichA It works! Thanks for the super-quick response. I will play with BlinkDB a bit more, it's a really well-structured codebase! Any plans to make the insertMany / updateMany functions faster? This is what I get in benchmarks:
The difference for inserts is quite unusual. And since we need to restore the application state on bootstrap, this might increase the app loading time significantly. But I would need to play with some realistic datasets before making further conclusions. Anyways, thanks again for the quick fix and have a great Sunday! |
Thanks for bringing the issue with bun to my attention in the first place :)
|
I have following issues when using blinkdb with bun.sh
$ bun run index.ts SyntaxError: Indirectly exported binding name 'Ids' is not found.
The fix is to export
Ids
as from db/remove.ts as type, like here:The other issue is with BTree, that I have posted here:
Not sure, if it's would require code changes in Blinkdb to make it work with bun.sh.
The text was updated successfully, but these errors were encountered: