Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement suggestion: Ignored base templates should not be removed from template.TemplateInfo.BaseTemplateIds #33

Open
vhil opened this issue Aug 19, 2020 · 1 comment

Comments

@vhil
Copy link

vhil commented Aug 19, 2020

At the moment, if I use default config which has the template exclusion rules on <templateReader> node:
<excludedBaseTemplate id="{8CA06D6A-B353-44E8-BC31-B528C7306971}" name="Rendering Parameters Template" />
I will have no possibility to know if the template is inherited from rendering parameters template or not.

What I would expect from this type of exclusion is that if we ignore that base template, it is obviously not included into de-serialized base templates property, as well as no fields from that base are template included into AllFields propery. However, I would still like to see base template ID in the template.TemplateInfo.BaseTemplateIds property.

That would mean that Leprechaun did read the .yaml properly, however did not de-serialize ignored base template.

Would that make sense?

@blipson89
Copy link
Owner

Yep! I'll add this to the backlog. I have a few ideas, but I need to figure out which one will work best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants