Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposing Controls twice freezes BlishHud #886

Open
flakysalt opened this issue May 27, 2023 · 0 comments · May be fixed by #887
Open

Disposing Controls twice freezes BlishHud #886

flakysalt opened this issue May 27, 2023 · 0 comments · May be fixed by #887

Comments

@flakysalt
Copy link

Adding a Control type like a button to a view multiple times crashes BlishHud when the View is being disposed of.

  1. Add a Control Type to a View twice (in my case, a button to a settings view)
  2. Set the buttons parent via the parent field
  3. add the button via .AddChild(button) again
  4. Observe BlishHud Freezing upon Disabling the Module

This is definitely a user error, but I would expect adding a control twice to be caught beforehand or an exception is thrown when the element is to be disposed of again.

@eksime eksime linked a pull request May 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant