-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathslogattrs.go
163 lines (127 loc) · 3.23 KB
/
slogattrs.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
package consistent
import (
"go/ast"
"go/types"
"github.com/go-toolsmith/astcast"
"golang.org/x/tools/go/analysis"
)
const (
slogAttrsBare = "bare"
slogAttrsAttr = "attr"
slogAttrsConsistent = "consistent"
)
type slogFunc struct {
name string
skipArgs int
}
var slogAttrsFlagAllowedValues = []string{flagIgnore, slogAttrsBare, slogAttrsAttr, slogAttrsConsistent}
var (
slogLoggerFuncs = []*slogFunc{
{name: "Debug", skipArgs: 1},
{name: "DebugContext", skipArgs: 2},
{name: "Error", skipArgs: 1},
{name: "ErrorContext", skipArgs: 2},
{name: "Info", skipArgs: 1},
{name: "InfoContext", skipArgs: 2},
{name: "Log", skipArgs: 3},
{name: "Warn", skipArgs: 1},
{name: "WarnContext", skipArgs: 2},
{name: "With"},
}
slogPackageFuncs = append(
append([]*slogFunc{}, slogLoggerFuncs...),
&slogFunc{name: "Group", skipArgs: 1},
)
)
func checkSlogAttrs(pass *analysis.Pass, call *ast.CallExpr, mode string) {
if mode == flagIgnore {
return
}
bare, attrs := slogCallArgs(pass, call)
switch {
case mode == slogAttrsBare && attrs:
reportf(pass, call.Pos(), "use bare arguments only")
case mode == slogAttrsAttr && bare:
reportf(pass, call.Pos(), "use Attr arguments only")
case mode == slogAttrsConsistent && bare && attrs:
reportf(pass, call.Pos(), "use consistent arguments (either bare or Attr)")
}
}
func slogCallArgs(pass *analysis.Pass, call *ast.CallExpr) (bool, bool) {
fun := slogFunction(pass, call)
if fun == nil {
return false, false
}
attrTyp := importPackageLookupType(pass, "log/slog", "Attr")
if attrTyp == nil {
return false, false
}
bare := false
attrs := false
args := call.Args[fun.skipArgs:]
for idx := 0; idx < len(args); idx++ {
expr := args[idx]
exprTyp := pass.TypesInfo.TypeOf(expr)
if types.AssignableTo(exprTyp, attrTyp) {
attrs = true
} else {
bare = true
// skip value
idx++
}
}
return bare, attrs
}
func slogFunction(pass *analysis.Pass, call *ast.CallExpr) *slogFunc {
sel := astcast.ToSelectorExpr(call.Fun)
if sel == astcast.NilSelectorExpr {
return nil
}
if fun := slogPackageFunction(sel); fun != nil {
return fun
}
return slogLoggerFunction(pass, sel)
}
func slogPackageFunction(sel *ast.SelectorExpr) *slogFunc {
pkg := astcast.ToIdent(sel.X).Name
if pkg != "slog" {
return nil
}
funIdent := astcast.ToIdent(sel.Sel)
if funIdent == astcast.NilIdent {
return nil
}
for _, fun := range slogPackageFuncs {
if fun.name == funIdent.Name {
return fun
}
}
return nil
}
func slogLoggerFunction(pass *analysis.Pass, sel *ast.SelectorExpr) *slogFunc {
slogLoggerType := importPackageLookupType(pass, "log/slog", "Logger")
if slogLoggerType == nil {
return nil
}
slogLoggerType = types.NewPointer(slogLoggerType)
loggerTyp := pass.TypesInfo.TypeOf(sel.X)
if !types.AssignableTo(loggerTyp, slogLoggerType) {
return nil
}
fun := astcast.ToIdent(sel.Sel).Name
for _, loggerFun := range slogLoggerFuncs {
if loggerFun.name == fun {
return loggerFun
}
}
return nil
}
func importPackageLookupType(pass *analysis.Pass, pkgName string, name string) types.Type {
for _, pkg := range pass.Pkg.Imports() {
if pkg.Path() != pkgName {
continue
}
return pkg.Scope().Lookup(name).Type()
}
return nil
}